fix(release): skip unrebased PRs in trusted version preparation - #49
Merged
Merged
Conversation
Master push enumerated every open PR and failed Prepare version when the PR had not integrated current master. Classify that as a branch update, write no record, and continue so unrelated open PRs cannot turn the trusted writer red.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cause
Hosted Prepare version (#47) failed after #48 merged. That job is version preparation, not npm publish and not Toolkit.
prepare-version.ymlon master push enumerates every open PR. PR #47 (and #2) still havebase.shaat pre-#48 master and do not contain current master, sovalidatePullRequest/merge-base --is-ancestorreject, and the entrypoint hid that asTrusted version preparation rejected. Same-head CI of #48 succeeded. npm remains1.22.0;1.22.1is unpublished on master.This is the same class as D56 (stale open PR vs advanced master). A classified non-zero exit would stay persistently red on every later master push.
Change
BranchUpdateRequiredErrorfor stale REST base and ancestry exit 1.reconcileVersionEventlogs it, writes no Git objects and no preparation record, and continues.PR #47 QualityLoop is untouched. No publish/tag/release/Toolkit mutation.
Toolkit
Automatic
wake-coordinatoron every CLI master push is not required for this stage or for the proven directpublish-npm.ymlpath. Removing it needs GitHubworkflowscope (this token cannot update.github/workflows/ci.yml). Dispatch-only coordinated receipt is kept.Local proof
Isolated WT from
95fc5f43948e06a4206cf53a812fd493a5619da3. Node 22.14.0, bun 1.3.8, isolated npm 11.12.1. Live SHA replay: first guard is nowBranchUpdateRequiredError, 0 writers, reconcile returnsnull.bun test tests/*.test.ts795 pass; typecheck; lint 0 errors; validate:cli-skills; actionlint on changed workflows; both builds; 31 smoke.Not in this PR
Publication of unpublished
1.22.1, merge of #47, Toolkit source, coordinator dispatch.