Skip to content

test: control the Retry-After deadline clock #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mohsen1 merged 1 commit into from
Nov 3, 2026
Merged

test: control the Retry-After deadline clock #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions tests/test_http.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1054,17 +1054,19 @@ async def test_polling_backoff_and_timeout_keep_review_url_and_last_record(


@MODES
async def test_retry_after_is_bounded_by_wait_deadline(mode: str) -> None:
async def test_retry_after_is_bounded_by_wait_deadline(
mode: str, monkeypatch: pytest.MonkeyPatch
) -> None:
clock = Clock(monkeypatch)
with Server(
lambda request, index: Reply(503, {"detail": "Unavailable."}, {"Retry-After": "2"})
lambda request, index: Reply(503, {"detail": "Unavailable."}, {"Retry-After": "20"})
) as server:
async with session(mode, server.url) as client:
started = time.monotonic()
result = await call(client, "wait_for_review", ORG, REVIEW, timeout=0.05)
result = await call(client, "wait_for_review", ORG, REVIEW, timeout=10)
assert result.status == "TIMED_OUT"
assert result.review_url == f"{server.url}/orgs/by-id/{ORG}/reviews/{REVIEW}"
assert time.monotonic() - started < 0.5
assert len(server.requests) == 1
assert clock.delays == [10]


@MODES
Expand Down