Skip to content

fix: validate review identity before CI verdict - #34

Open
silbulatovich wants to merge 2 commits into
prooflinedev:mainfrom
silbulatovich:fix/ci-review-identity
Open

silbulatovich wants to merge 2 commits into
prooflinedev:mainfrom
silbulatovich:fix/ci-review-identity

Conversation

@silbulatovich

Copy link
Copy Markdown

Problem

ci review could exit successfully when the review detail response belonged to a different review or commit. Identity validation was enforced for SARIF output, but not consistently before computing CI verdicts.

Reproduced with an HTTP integration test committed separately before the fix.

Fix

  • Validate the review ID on every detail read, including during polling.
  • Verify the commit SHA, review type, and repository UUID before accepting a CI result.
  • Reuse identity validation across output modes.
  • Preserve compatibility with older API responses and renamed repositories.

Testing

  • 95 tests passed; 1 ignored (requires pre-commit).
  • Original regression test confirmed failing before the fix and passing afterward.
  • cargo fmt, Clippy, and cargo deny passed (cargo deny reported existing dependency warnings).

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant