Repository navigation
class: fix multi instance behaviour - #7
Merged
Merged
Conversation
The main.jsonnet compile entry used a hard-coded output_path
(solution-backup/), so compiling multiple instances of this component
into one catalog would make every instance render into the same
directory, overwriting each other's manifests.
Use ${_instance} as output_path, like the newer component templates do,
and move the golden test dirs accordingly (instance name == test name).
Also update the espejote render test's manifest path.
Mirrors appuio/component-solution-base-monitoring#13.
BacLuc
added
bug
|
🚀 This PR has been released as Triggering workflows 🛠️ Auto tagging enabled with label |
Collaborator
Author
|
using approval from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main.jsonnet compile entry used a hard-coded output_path (solution-backup/), so compiling multiple instances of this component into one catalog would make every instance render into the same directory, overwriting each other's manifests.
Use ${_instance} as output_path, like the newer component templates do, and move the golden test dirs accordingly (instance name == test name). Also update the espejote render test's manifest path.
Mirrors appuio/component-solution-base-monitoring#13.