Skip to content

Initial implementation - #1

Open
mdnix wants to merge 6 commits into
masterfrom
initial-implementation
Open

Initial implementation#1
mdnix wants to merge 6 commits into
masterfrom
initial-implementation

Conversation

@mdnix

@mdnix mdnix commented Aug 7, 2026 •
edited by simu
Loading

Copy link
Copy Markdown
Collaborator

Checklist

  • The PR has a meaningful title. It will be used to auto-generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Update the documentation.
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.
  • Link this PR to related issues or PRs.

@mdnix mdnix self-assigned this Aug 7, 2026
@mdnix
mdnix force-pushed the initial-implementation branch from 167732a to bc1a747 Compare August 7, 2026 12:59
@mdnix mdnix added enhancement New feature or request bump:minor Create a new minor release when merging the labeled PR labels Aug 7, 2026
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

🚀 Merging this PR will release v0.1.0

Merging will trigger workflows Release

🛠️ Auto tagging enabled with label bump:minor

@mdnix
mdnix marked this pull request as ready for review August 11, 2026 10:05
@mdnix
mdnix requested a review from a team August 11, 2026 10:05
simu
simu reviewed Aug 11, 2026
View reviewed changes
Comment thread class/defaults.yml Outdated
Comment thread component/app.jsonnet Outdated
Comment thread docs/modules/ROOT/pages/references/parameters.adoc Outdated
Comment thread docs/modules/ROOT/pages/references/parameters.adoc Outdated
Comment thread docs/modules/ROOT/pages/references/parameters.adoc Outdated
@mdnix

mdnix commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator Author

Example implementation relying on component-gateway-api projectsyn/component-kgateway#13

@mdnix
mdnix requested a review from simu August 11, 2026 12:59
simu
simu reviewed Aug 11, 2026
View reviewed changes

@simu simu left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs LGTM now. As noted in the other PR, the aggregated RBAC for the core resources should probably be managed by this component.

@mdnix

mdnix commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator Author

Docs LGTM now. As noted in the other PR, the aggregated RBAC for the core resources should probably be managed by this component.

Done. Aggregated RBAC is now handled by this new component.

@mdnix
mdnix requested a review from simu August 11, 2026 14:05
@mdnix
mdnix force-pushed the initial-implementation branch from f6c37f7 to 6d77ee7 Compare August 12, 2026 08:57
simu
simu reviewed Aug 12, 2026
View reviewed changes
Comment thread component/main.jsonnet
Comment on lines +25 to +35
std.parseInt(
std.get(
std.get(
inv.parameters,
'dynamic_facts',
{}
),
'openshiftVersion',
{ Minor: '0' }
).Minor
) >= 19;

@simu simu Aug 12, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We currently try to avoid using dynamic facts directly in components. Instead, we usually have a component parameter that's set to some static default value and which can be set to the dynamic fact in the VSHN global defaults.

See e.g. https://github.com/appuio/component-openshift4-console/blob/b3346c61807fd2ec86cb0c3dc8902da6e805e573/class/defaults.yml#L15-L17

@simu simu Aug 12, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, this is copied from airlock-microgateway-operator... if you don't mind, I'd like to change this to the best practice variant in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simu simu simu left review comments

Assignees

@mdnix mdnix

Labels

bump:minor Create a new minor release when merging the labeled PR enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mdnix @simu