WIP Lots of improvements - #898
Draft
snazy wants to merge 30 commits into
Draft
Conversation
snazy
force-pushed
the
broad-review-fixes
branch
20 times, most recently
from
July 23, 2026 15:31
57f38e8 to
48e5ab6
Compare
snazy
force-pushed
the
broad-review-fixes
branch
6 times, most recently
from
July 28, 2026 14:53
11e9436 to
e38a833
Compare
snazy
force-pushed
the
broad-review-fixes
branch
3 times, most recently
from
August 8, 2026 07:30
8552e16 to
7ca44dc
Compare
snazy
force-pushed
the
broad-review-fixes
branch
from
August 17, 2026 09:40
7ca44dc to
529f537
Compare
* Replace `Arrays.asList()` with single element with `List.of()` * enhanced switch expression * pattern variable * Use String.repeat() * Use `.isEmpty()` * Remove unused `ParseError` * Remove unused function in TypeErrors * Remove duplicate `if`
Struct-pruning was effectively doing nothing.
Cache source-specific accessors for generated protobuf messages and Jackson 2/3 properties. Convert CEL maps directly to protobuf map entries while retaining descriptor-based fallbacks and regression coverage for representative value types.
Make TypeAdapter the bidirectional conversion boundary. Keep Val.convertToNative() as the deprecated compatibility fallback, preserve primitive and range semantics, and route containers and environments through their configured adapters.
Add fixed evaluators and operations for three-, four-, and five-argument overloads. Retain generic dispatch, error and unknown ordering, receiver fallback, cost, and decorator behavior for unsupported paths.
Extend generated protobuf access and optimize CEL map/list operations, traversal, scalar reuse, and cost calculation. Retain generic fallbacks and CEL equality, error, unknown, and numeric semantics.
Eliminate temporary activation-lookup values and centralize numeric comparison and equality semantics. Add evaluator-boundary benchmarks and coverage for numeric boundaries, NaN, and signed zero.
Evaluate supported checked scalar expressions without intermediate Val wrappers. Keep unsupported syntax, custom adapters and providers, decorators, and incompatible overloads on the standard interpreter while preserving result, error, unknown, cost, and evaluation-order semantics.
Plan native list concatenation, scalar-list consumers, exact protobuf field selection, and dynamic string-keyed map access. Preserve interpreter fallback and add differential, planner-shape, and benchmark coverage.
Extend consumer-scoped native evaluation for aggregate/list consumers, list concatenation, maps, folds, and equality. Preserve CEL construction order and exceptional-value semantics while avoiding intermediate CEL collections on supported paths.
Add benchmark modules and representative workloads for core, protobuf, Jackson, and native-evaluation paths.
Optimize exact indexing of Jackson object-valued maps without materializing intermediate CEL values. Retain dynamic lookup and adapter fallback behavior.
Recognize constant regular-expression patterns during planning and reuse compiled expressions while retaining runtime behavior for dynamic patterns.
Gate native planning for supported nested quantifiers and add coverage for allocation-sensitive evaluation paths. Unsupported shapes retain interpreter execution.
Add comparison benchmarks for optimized evaluator paths and their baseline controls.
Return parse issues from environment compilation, preserve protobuf type-value adaptation, isolate partial activation patterns, and retain registry identity when extending environments.
Remove the unused conformance BOM entry and register transitive protobuf dependencies explicitly.
Validate Jackson map keys before adaptation and report unsupported key types consistently in the Jackson 2 and Jackson 3 integrations.
Adapt repeated generated protobuf message fields with the same registry and type semantics as singular message fields.
Compile benchmark expressions at the intended lifecycle boundary so setup and measurement paths remain distinct.
Defensively retain source line offsets so callers cannot alter source-location calculations after construction.
Limit the supported release line, remove obsolete build configuration, resolve release POMs from version tags, and restore the Protobuf 3 build and test variants.
Use RE2/J semantics for CEL regular expressions and update conformance and standalone coverage for the supported behavior.
Register standalone Jackson enums, align array field types with CEL adaptation, and allow configured recursive Jackson registries.
Correct protobuf type overrides, live list sizing, frozen environment handling, map value adaptation, iterator behavior, and database copying.
Use the configured TypeRegistry in ScriptHost, introduce ScriptCompiler, correct unknown handling and source locations, and isolate EvalState between evaluations.
Update Javadocs and public documentation to describe the current APIs, evaluation behavior, and supported integrations.
Publish the CEL-Java source archive as part of the cel-standalone artifact.
Add configurable resource limits for CEL parsing, compilation, and evaluation, with public API and documentation coverage.
snazy
force-pushed
the
broad-review-fixes
branch
from
August 20, 2026 10:31
692827f to
4cd9755
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.