Repository navigation
Add the final Definition of Done audit and test invalid-prediction rejection - #66
Merged
Merged
Conversation
…jection docs/definition_of_done.md maps each Definition of Done item to its status (done, done within a stated limit, or out of scope) and its evidence. Auditing item 9 showed that no test covered the API refusing a prediction whose span lies outside the text; test_invalid_prediction_is_rejected_not_shown now does (and fails if the guard is removed).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/definition_of_done.md: every Definition of Done item with status (✅ done · 🟨 done within a stated limit · ⛔ out of scope) and evidence links; linked from the README's project status. 13 ✅, 4 🟨 (labels mostly model-drafted, held-out results are agreement, transformers not on target host), plus roadmap items: prospective check 🟨, challenge set ⛔, usability study ⛔.invalid_predictionrefusal (a CI requirement: output-validator rejection).test_invalid_prediction_is_rejected_not_shownwraps the real extractor to emit an out-of-bounds span and asserts a 500invalid_prediction, twice (not cached). Mutation check: the test fails when the guard is disabled.