test(eval): actually isolate eval repositories - #253
Merged
Conversation
The isolateRepo: true override in evals/it.ts had no effect: vitest's
extend() does not remap dependency references of fixtures defined in an
earlier layer, so the repo fixture still saw isolateRepo: false and every
eval ran against the shared repository. Evals polluted each other's state
(leftover previews, locales, and types), causing spurious failures.
Replace the dead override with it.scoped({ isolateRepo: true }), the one
vitest path that remaps fixture deps. It runs at module scope in
evals/it.ts, which re-executes during each eval file's collection, so
every eval test gets a throwaway repository.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
angeloashmore
force-pushed
the
aa/isolate-eval-repos
branch
from
August 3, 2026 21:50
d8d1ff2 to
bbac8eb
Compare
lihbr
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves:
Description
Evals were sharing a repo inadvertently. Each eval should be using its own repo. This fixes it.
Checklist
Preview
How to QA 1
Run the evals and check that each test creates a
prismic-cli-isolated-*repository.🤖 Generated with Claude Code
Footnotes
Please use these labels when submitting a review:
⚠️ #issue: Strongly suggest a change.
❓ #ask: Ask a question.
💡 #idea: Suggest an idea.
🎉 #nice: Share a compliment. ↩