PTE Build Signatures fix modify error - #94
Open
PropmanProphecy wants to merge 1 commit into
Open
Conversation
PropmanProphecy
requested review from
Tomshoej
and
a lite review from Copilot
September 1, 2026 10:14
There was a problem hiding this comment.
🟡 Changes recommended
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR adjusts how the “last signature” temporary record is persisted during signature building, aiming to avoid a Modify() error during the swap/update logic.
Changes:
- Replaces
LastSignatureTMP.Modify();with anif LastSignatureTMP.Modify() then;call to suppress modify failures.
File summaries
| File | Description |
|---|---|
| BuildSignatures/PTEBuildSignatures.CodeUnit.al | Updates how the temporary “last signature” record is modified during signature ordering logic. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| LastSignatureTMP."Assembly Order" := AssemblyOrder; | ||
| LastSignatureTMP.Indent := Indentation; | ||
| LastSignatureTMP.Modify(); | ||
| if LastSignatureTMP.Modify() then; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.