Repository navigation
feat(pixi-build-ros): name packages as RoboStack does - #7539
Merged
Hofer-Julian merged 2 commits intoNov 17, 2026
Merged
Conversation
This was referenced Nov 13, 2026
Tobias-Fischer
force-pushed
the
pixi-build-ros-names
branch
from
November 13, 2026 19:43
0a730a9 to
a4bda37
Compare
2 of 3 tasks
Contributor
Author
Tobias-Fischer
added a commit
to Tobias-Fischer/vinca-rs
that referenced
this pull request
Nov 14, 2026
* ros_workspace's activation scripts live here again; follow the split pixi PRs pixi-build-ros's recipe-rules PR was split into prefix-dev/pixi#7539/#7540/#7541, and `pixi build` doesn't use the activation scripts, so they stay with the recipe generator. Repinned to the end of that stack (pixi-build-ros-requirements). Parity: the same 44,950 recipes as 0.1.7 (4 distros x 5 platforms). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Follow the rebased pixi PRs; rattler-build#2943 directly pixi-build-ros now comes from the end of the rebased pixi PRs (#7539 on main, #7540, #7541 with #7533 merged in). pixi main moved to rattler_solve 13 and the rattler-build 0.2.25 crates, so rattler_build_core is pinned to #2943's own branch (no older-commit integration branch any more) and the rattler pins follow (rattler_build_recipe/variant_config 0.1.25, rattler_solve 13). The Cargo.toml comment lists the pixi PRs' merge order. Parity: the same 44,950 recipes as 0.1.7 (4 distros x 5 platforms). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Per-package recipe files from the config (files/<pkg>/) ros_workspace's activation scripts move to the distribution config (RoboStack/robostack shared/files/ros2-ros-workspace/), next to the patches and tests: any files/<pkg>/ folder of a config layer is copied into that package's recipe directory. The ros_workspace special case and the embedded scripts go. Also follows the pixi PRs to ab454118b (Ninja for ament_cmake on Windows, a dead ros-humble block dropped). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
RoboStack's canonical names for ROS 2 are `ros2-<name>`; `ros-<distro>-<name>` are only compatibility aliases. The backend now uses them for the package it builds, for unmapped and `ros:`-mapped dependencies, and for workspace siblings (`Distro::conda_name`). ROS 1 keeps `ros-<distro>-<name>`: robostack-noetic only publishes those names. ROS 2 names no longer say which distribution a package belongs to, so the distro mutex in host and run is pinned to it: `ros2-distro-mutex * <distro>_*` (`Distro::mutex_spec`; RoboStack builds the mutex with the build string `<distro>_<build number>`). Merging that with a mutex the user declares (e.g. `0.5.*`) needs merged specs to keep a build string: `merge_specs` now merges the versions and keeps the build string of either side (conflicting build strings are an error). The docs say how to migrate a `pixi.toml` that names ROS 2 path dependencies `ros-<distro>-<name>`. The integration tests and the docs' example workspace use the new names, and the test workspace requires macOS 14: RoboStack's `ros2-*` builds need `__osx >=14` (the old names still resolved to older builds). Snapshot changes: - the jazzy inline snapshots (generate_recipe, condition_evaluation_*) name everything `ros2-<name>` instead of `ros-jazzy-<name>`, and the mutex is `ros2-distro-mutex * jazzy_*` - in the noetic .snap files `ros-distro-mutex` is `ros-distro-mutex * noetic_*` in host and run, and in generate_recipe_with_mutex_version the user's `0.5.*` merges into `ros-distro-mutex 0.5.* noetic_*` Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Tobias-Fischer
force-pushed
the
pixi-build-ros-names
branch
from
November 14, 2026 12:15
a4bda37 to
df012d7
Compare
Tobias-Fischer
marked this pull request as ready for review
November 17, 2026 07:18
Contributor
Author
|
This is ready for review @Hofer-Julian |
Fix Python executable paths, pin the build distro, and preserve qualified dependencies when merging unconstrained specs. Accept compatible exact mutex build pins. Verified with 97 Rust tests, 27 integration probes, and pixi run typos.
Hofer-Julian
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part 1 of 3, split out of #7535 for easier review: this one, then #7540 (build scripts), then #7541 (requirement rules). It applies directly to main and doesn't depend on #7533.
Tobi's human description
We have recently changed the names of packages in RoboStack. They are now
ros2-<name>withros-<distro>-*as compatibility packages. This PR changes the behaviour of pixi-build-ros to match RoboStack behaviour, except for ROS 1 which keeps the name.The PR also pins the mutex.
It also encourages the new behaviour in the docs, which still point to the old names.
AI-generated details (Claude Opus 5.5)
Names: ROS 2 packages are
ros2-<name>, as RoboStack publishes them (ros-<distro>-*remain as compatibility packages there). ROS 1 keepsros-<distro>-<name>, because robostack-noetic only publishes those names.Distro::conda_namenames the built package, unmapped andros:-mapped dependencies, and workspace siblings.Mutex: the ROS 2 names don't say which distribution a package belongs to, so the distro mutex in host and run is pinned:
ros2-distro-mutex * <distro>_*(Distro::mutex_spec). Merging it with a mutex the user declares (e.g.0.5.*) keeps the build string:merge_specsmerges the versions and keeps either side's build string, and conflicting build strings are an error.Migration: a
pixi.tomlthat names a ROS 2 path dependencyros-<distro>-<name>has to rename it toros2-<name>; the backend docs now say so. RoboStack'sros2-*builds need macOS 14 (__osx >=14), so on macOS the workspace needs[system-requirements] macos = "14.0"(the old names still resolved to older builds). The docs mention it, and the integration tests' workspace sets it.Not changed here: the docs' example ROS workspace uses the new names in its
pixi.toml, but itspixi.lockneeds a released backend to re-lock, so that should follow in a separate PR.ros-<distro>-.test_ros.py) expect the new names; they pass locally on osx-arm64 (10 passed, 1 skipped).ros2-<name>and pinros2-distro-mutex * jazzy_*. In the noetic snapshots only the mutex changes, toros-distro-mutex * noetic_*.cargo test -p pixi-build-ros,cargo clippy -p pixi-build-ros --all-targets -- -D warnings,cargo fmt --check,pixi run typos,check-into-diagnostic.Checklist:
🤖 Generated with Claude Code