Skip to content

Add a notification step for failed tests - #899

Closed
MakisH wants to merge 2 commits into
developfrom
tests/notify
Closed

Add a notification step for failed tests#899
MakisH wants to merge 2 commits into
developfrom
tests/notify

Conversation

@MakisH

@MakisH MakisH commented Aug 14, 2026

Copy link
Copy Markdown
Member

Adds a step to send a Matrix notification in case the system tests fail, similarly to https://github.com/precice/precice/blob/develop/.github/workflows/performance-regression.yml

I would like to further restrict this to scheduled runs only, but this is currently a reusable workflow and all other workflows call it (without further steps). Still, not too many manual tests should fail in the near future.

The needed secrets are already shared with this repository.

@MakisH MakisH self-assigned this Aug 14, 2026
@MakisH
MakisH requested a lite review from Copilot August 14, 2026 15:01

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a failure-only notification step to the reusable system test workflow so maintainers get a Matrix message when a system test run fails.

Changes:

  • Add a Matrix notification step using precice/notify-action@v1 gated by if: ${{ failure() }}.
  • Wire Matrix connection parameters via repository variables and a secret.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment on lines +103 to +108
uses: precice/notify-action@v1
with:
homeserver: ${{ vars.MATRIX_BOT_HOMESERVER }}
login: ${{ vars.MATRIX_BOT_LOGIN }}
password: ${{ secrets.MATRIX_BOT_PASSWORD }}
room_id: ${{ vars.MATRIX_BOT_ROOMID }}

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This actually means that we would need to share the secrets also with every repository that calls the system tests.

@MakisH
MakisH requested a lite review from Copilot and removed request for Copilot August 14, 2026 17:20
@MakisH

MakisH commented Aug 14, 2026

Copy link
Copy Markdown
Member Author

I think this is getting complicated, without much of added value. We already have the labels and are integrating test suites in the CI of each repository.

I am also getting email notifications on every failure of the scheduled run, and I am the one that will have to fix it or trigger others.

@MakisH MakisH closed this Aug 14, 2026
@MakisH
MakisH deleted the tests/notify branch August 14, 2026 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants