Remove unused Python imports and dependencies - #896
Merged
MakisH merged 3 commits intoAug 14, 2026
Conversation
MakisH
approved these changes
Aug 14, 2026
MakisH
left a comment
Member
There was a problem hiding this comment.
Thank you for the contribution! I guess that #833 is now sufficiently addressed.
The system tests pass, and I looked over all files, I don't see anything wrong: all removed imports are not mentioned anywhere in the file.
The repository-wide
check-nameshook also ran, but reports pre-existing permalink errors in unchanged README files.
Where do you see that? check-names passes on the CI.
It would be useful to have such a check for unused imports as a pre-commit hook.
| import sys | ||
| import matplotlib.pyplot as plt | ||
| from mpl_toolkits.mplot3d import Axes3D | ||
| from mpl_toolkits.mplot3d import Axes3D # noqa: F401 - registers projection='3d' on Matplotlib <3.2 |
Member
There was a problem hiding this comment.
I would argue that matplotlib 3.2 is already too old, but we don't have version restrictions for this script yet, so that's all good for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
matplotlibandnumpyfrom the two participants that no longer use themAxes3Dside-effect import needed by supported Matplotlib versions before 3.2Testing
uvx ruff check . --select F401python3 -m py_compileprint_metadata.py,print_test_suites.py, andsystemtests.py --help--check --fail-on-outdatedThe repository-wide
check-nameshook also ran, but reports pre-existing permalink errors in unchanged README files.Checklist
changelog-entries/896.mdrequirements-reference.txtfiles for changed requirementsFixes #833