fix: strip trailing slash from PACKAGE_DIR in scanner-env.sh to fix w… - #8764
Merged
Conversation
…heel build CI
## Problem
Wheel build jobs always skipped with `Skipping - no .sh changes` even when
a `.sh` file was changed.
## Root Cause
`PACKAGE_DIR` was read from `build_info.json` without stripping the trailing
slash (e.g. `"n/nbconvert/"`), causing the wheel job grep to expand as:
grep -E "^n/nbconvert//.*\.sh$" ← double slash, never matches
## Fix
Added `PACKAGE_DIR="${PACKAGE_DIR%/}"` in the "Create scanner-env.sh" step,
mirroring what the "Set job control flags" step already does correctly.
cdeepali
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…heel build CI
Problem
Wheel build jobs always skipped with
Skipping - no .sh changeseven when a.shfile was changed.Root Cause
PACKAGE_DIRwas read frombuild_info.jsonwithout stripping the trailing slash (e.g."n/nbconvert/"), causing the wheel job grep to expand as:grep -E "^n/nbconvert//.*.sh$" ← double slash, never matches
Fix
Added
PACKAGE_DIR="${PACKAGE_DIR%/}"in the "Create scanner-env.sh" step, mirroring what the "Set job control flags" step already does correctly.Checklist
set -eoption enabled and observe success ?