Skip to content

Pyav==v18.1.0 - #8758

Open
tejasBadjateIBM wants to merge 12 commits into
ppc64le:masterfrom
tejasBadjateIBM:pyav
Open

Pyav==v18.1.0 #8758
tejasBadjateIBM wants to merge 12 commits into
ppc64le:masterfrom
tejasBadjateIBM:pyav

Conversation

@tejasBadjateIBM

Copy link
Copy Markdown
Contributor

Checklist

  • Have you checked and followed all the points mention in the CONTRIBUTING.MD
  • Have you validated script on UBI 10.2 container
  • Did you run the script(s) on fresh container with set -e option enabled and observe success ?
  • Did you have Legal approvals for patch files ?

Comment thread p/pyav/pyav_ubi_10.2.sh Outdated
cd $CURRENT_DIR
git clone https://github.com/xiph/opus
cd opus
git checkout v1.3.1

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use opus version v1.5.2

Comment thread p/pyav/pyav_ubi_10.2.sh
Comment on lines +218 to +224
if version_ge "$VERSION_STR" "17.0.0"; then
echo "PyAV version $PACKAGE_VERSION requires FFmpeg 8.0+. Checking out n8.0.1..."
git checkout n8.0.1
else
echo "PyAV version $PACKAGE_VERSION requires legacy FFmpeg. Checking out n7.1..."
git checkout n7.1
fi

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated ffmpeg==v9.0.1 (latest)

Comment thread p/pyav/pyav_ubi_10.2.sh Outdated
cd $CURRENT_DIR
git clone https://github.com/python-pillow/Pillow
cd Pillow
git checkout 11.1.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use pillow version 12.3.0.

@prathamesh-ibm prathamesh-ibm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment thread p/pyav/pyav_ubi_10.2.sh Outdated

# Conditionally checkout FFmpeg based on PyAV version
if version_ge "$VERSION_STR" "17.0.0"; then
echo "PyAV version $PACKAGE_VERSION requires FFmpeg 8.0+. Checking out n8.0.1..."

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edit the echo stmt to reflect the version 9 instead of 8

@rashmi-ibm rashmi-ibm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants