Cares==1_19_1 ubi10.2 - #8725
Open
tejasBadjateIBM wants to merge 33 commits into
Open
Conversation
This reverts commit 8ef46c4.
Contributor
|
Check the build failure https://github.com/ppc64le/build-scripts/actions/runs/33722632017/job/100546784493?pr=8725 |
tejasBadjateIBM
marked this pull request as draft
September 3, 2026 12:45
tejasBadjateIBM
marked this pull request as ready for review
September 6, 2026 04:48
prathamesh-ibm
suggested changes
Sep 8, 2026
Comment on lines
+103
to
+106
| test -f ${SITE_PACKAGE_PATH}/cares/include/ares.h || { echo "ERROR: ares.h not exists." ; exit 1; } | ||
| test -f ${SITE_PACKAGE_PATH}/cares/lib/libcares.so || { echo "ERROR: libcares.so not exists." ; exit 1; } | ||
| test ! -f ${SITE_PACKAGE_PATH}/cares/lib/libcares.a || { echo "ERROR: libcares.a exists." ; exit 1; } | ||
| test ! -f ${SITE_PACKAGE_PATH}/cares/lib/libcares_static.a || { echo "ERROR: libcares_static.a exists." ; exit 1; } No newline at end of file |
Contributor
There was a problem hiding this comment.
Can you also execute the test command instead of just validating whether the file exists?
Check https://github.com/ppc64le/build-scripts/blob/master/c/c-ares/cares_ubi_9.3.sh#L99C1-L112C3
rashmi-ibm
reviewed
Sep 9, 2026
| fi | ||
| SITE_PACKAGE_PATH=$(python3.14 -m pip show c-ares | awk -F': ' '/^Location:/ {print $2}') | ||
|
|
||
| test -f ${SITE_PACKAGE_PATH}/cares/include/ares.h || { echo "ERROR: ares.h not exists." ; exit 1; } |
Contributor
There was a problem hiding this comment.
I don't think we explicitly need to check if these files exists, any specific reason for checking these?
Running the ninja test should be sufficient.
Contributor
Author
There was a problem hiding this comment.
These validations were present in the script that Nayana shared.
Contributor
|
@tejasBadjateIBM , can you squash all your commits into a single commit. After that we are good to merge this pr. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
set -eoption enabled and observe success ?