Restore Chunk with result selector for IAsyncEnumerable - #881
Open
wxxb789 wants to merge 1 commit into
Open
Conversation
The `Chunk` overloads taking a result selector were lost when Funcky.Async was integrated into Funcky. .NET 10 provides `AsyncEnumerable.Chunk(source, size)`, but no selector overloads.
Member
|
Thank you for your contribution, I'll take a look tomorrow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Chunkoverloads onIAsyncEnumerablewere not carried over whenFuncky.Asyncwas integrated intoFuncky, so they are missing fromFuncky3.6 onnet10.0while they still exist inFuncky.Async1.4.1..NET 10 ships
AsyncEnumerable.Chunk(source, size)(including the validation ofsize), so I did not port the overload without a result selector — it would be shadowed by the BCL one. The three overloads taking a result selector have no BCL equivalent and are restored here.SelectAwaitdoes not exist inSystem.Linq.AsyncEnumerable, soChunkAwaituses theSelectoverload taking aCancellationTokeninstead, the same wayWhereSelectAwaitdoes.