Selection.tsx Recurses Infinitely #330 - #342
Closed
dklwo wants to merge 1 commit into
Closed
Conversation
- cause: react 19 surfaces an existing issue where Select is reactively consuming an api that it also pushes updates to
Collaborator
|
Thanks for catching this and for the fix attempt. This ended up needing a slightly different shape to cover a few edge cases we found along the way - landed in #359. Closing this one as superseded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue: react 19 surfaces an existing issue where Select is reactively consuming an api that it also pushes updates to
fix: create seperate api for select component and effect components to consume