Skip to content

fix(web): show unlinked icon when viewport aspect ratio is unlocked - #6509

Merged
maria-rcks merged 2 commits into
pingdotgg:mainfrom
UtkarshUsername:feat/web/aspect-ratio-unlink-icon
Aug 13, 2026
Merged

fix(web): show unlinked icon when viewport aspect ratio is unlocked#6509
maria-rcks merged 2 commits into
pingdotgg:mainfrom
UtkarshUsername:feat/web/aspect-ratio-unlink-icon

Conversation

@UtkarshUsername

@UtkarshUsername UtkarshUsername commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

What Changed

Changed the aspect ratio lock button in the device toolbar of the in-app browser. The linked (locked) and unlinked (unlocked) states now use distinct icons: Link2 when the ratio is locked, Unlink2 (the matching broken-chain icon from Lucide) when it is unlocked.

Why

Both states previously rendered the same Link2 icon, which gave no visual signal of the current state. The difference was not clear visually. Unlink2 is the exact counterpart to Link2.

UI Changes

Before:
image
image

After:
image
image

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes

Note

Low Risk
Purely visual icon swap in the preview device toolbar with no logic or API changes.

Overview
The browser device toolbar aspect-ratio lock control now uses two icons instead of always showing Link2: Unlink2 when the ratio is unlocked (aspectRatio === null) and Link2 when it is locked. Labels, aria-pressed, and toggle behavior are unchanged—only the icon reflects state.

Reviewed by Cursor Bugbot for commit 3ea1725. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Show unlinked icon in BrowserDeviceToolbar when viewport aspect ratio is unlocked

The aspect ratio toggle button previously always showed the Link2 icon regardless of lock state. It now conditionally renders Unlink2 when aspectRatio is null and Link2 when locked.

Macroscope summarized 207a588.

@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d789e3b6-a897-4456-b8cf-ba31b1374f1d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. label Aug 13, 2026
@github-actions github-actions Bot added the size:XS 0-9 changed lines (additions + deletions). label Aug 13, 2026
@macroscopeapp

macroscopeapp Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved 3ea1725

This change is a minor UI adjustment that conditionally displays an Unlink2 or Link2 icon based on existing aspectRatio state. It's purely visual feedback with no runtime behavior changes beyond icon rendering.

You can customize Macroscope's approvability policy. Learn more.

@maria-rcks
maria-rcks merged commit 2fab18e into pingdotgg:main Aug 13, 2026
18 checks passed
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Aug 13, 2026
## What's Changed
* fix(mobile): prevent invalid HTML entities from crashing markdown by @Lucenx9 in pingdotgg/t3code#6495
* fix(web): avoid Clerk close button overlap by @t3-code[bot] in pingdotgg/t3code#6442
* fix(web): show unlinked icon when viewport aspect ratio is unlocked by @UtkarshUsername in pingdotgg/t3code#6509
* fix(web): scope pull request errors to their environment by @Adamulek123 in pingdotgg/t3code#6490
* fix(mobile): show a real settings cog in the Android sidebar header by @paul-vd in pingdotgg/t3code#6520

## New Contributors
* @Adamulek123 made their first contribution in pingdotgg/t3code#6490
* @paul-vd made their first contribution in pingdotgg/t3code#6520

**Full Changelog**: pingdotgg/t3code@v0.0.34-nightly.20260813.1087...v0.0.34-nightly.20260813.1088

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.34-nightly.20260813.1088
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants