fix(web): pull request action menus no longer show duplicate dividers

[RakshithBhat03]

Pull request action menus could show two dividers back to back when every permission-gated management action was unavailable. The empty section made the menu look like an action had failed to render.

Dividers around the optional management section now render only when it contains an action, and the merge-method divider only appears when another management action precedes it. This covers every combination of draft and ready-for-review actions, auto-merge, and merge-method choices without changing the surrounding environment, conflict, or close and reopen groups.

Verification

• vp test run apps/web/src/components/pullRequest/pullRequestDetail.logic.test.ts apps/web/src/components/pullRequest/PullRequestListFilters.test.tsx — 67 tests passed.
• vp run -F @t3tools/web typecheck
• vp lint apps/web/src/components/pullRequest/PullRequestDetailPanel.tsx apps/web/src/components/pullRequest/pullRequestDetail.logic.ts apps/web/src/components/pullRequest/pullRequestDetail.logic.test.ts --report-unused-disable-directives
• Checked in local web and macOS development builds.

Before	After

---

Built by GPT-5.6 in T3 Code through the Codex harness.

---

Note

Low Risk
Presentation-only menu layout change in the pull request detail panel; no API or permission behavior changes.

Overview
Fixes duplicate menu dividers in the pull request detail ⋯ actions menu when draft/ready, auto-merge, and merge-method entries are all hidden by permissions or state.

Adds resolvePullRequestManagementMenuLayout so the optional management block (and its separators) render only when at least one of those actions is visible, and the divider before merge-method radios appears only when another management item sits above them. PullRequestDetailPanel uses explicit show* flags for each item instead of inlined conditions. Covered by an exhaustive combination test in pullRequestDetail.logic.test.ts.

^{Reviewed by Cursor Bugbot for commit 65562f3. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix duplicate dividers in pull request action menus

Adds resolvePullRequestManagementMenuLayout in pullRequestDetail.logic.ts to compute whether the management menu group and its internal separator should render. In PullRequestDetailPanel, the entire management block is now conditional on at least one action being available, and the separator before merge methods only renders when a management action is also present.

^{Macroscope summarized 65562f3.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 4624e1e8-55c7-4888-9530-b14a758b2c41

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Approved 65562f3

This is a straightforward UI bug fix that prevents duplicate menu dividers. The changes extract existing conditions into variables and add a well-tested helper function to control separator visibility. No functional behavior changes beyond the visual fix.

^{You can customize Macroscope's approvability policy. Learn more.}