Skip to content

fix(web): avoid duplicate command details - #6498

Open
imran-vz wants to merge 1 commit into
pingdotgg:mainfrom
imran-vz:bug/fix-duplicate-command-details
Open

fix(web): avoid duplicate command details#6498
imran-vz wants to merge 1 commit into
pingdotgg:mainfrom
imran-vz:bug/fix-duplicate-command-details

Conversation

@imran-vz

@imran-vz imran-vz commented Aug 13, 2026

Copy link
Copy Markdown

What Changed

  • Deduplicated repeated command metadata in expanded web and desktop tool-call rows.
  • Preserved distinct command output and file details.
  • Added regression coverage for duplicate commands and legitimate command output.

Why

Codex command activities can contain the same shell-wrapped command in both rawCommand and detail. The expanded renderer displayed both fields without deduplication, making it look like every command ran twice.

Deduplicating display blocks in the presentation layer fixes existing and active sessions without changing provider data or command execution behavior. It also matches the existing mobile implementation.

UI Changes

Before

file-8e1320a96958fa062798e0f4b0446d80

After

image

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes

Note

Low Risk
UI-only presentation change in the messages timeline with no backend or execution impact; behavior is covered by new unit tests.

Overview
Expanded chat tool-call rows no longer repeat the same command when Codex activities put an identical shell-wrapped string in both rawCommand and detail.

buildToolCallExpandedBody is moved from MessagesTimeline.tsx into MessagesTimeline.logic.ts and builds the expanded body from ordered, deduplicated blocks (MCP payload, command/raw command, detail, changed files). Distinct output—e.g. pwd vs its cwd—is still shown on separate lines. Regression tests cover duplicate metadata and legitimate multi-block output.

Provider data and command execution are unchanged; this is presentation-only and aligns with the mobile appendUniqueBlock pattern.

Reviewed by Cursor Bugbot for commit 4610025. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Fix duplicate command details in tool call expanded body

Extracts buildToolCallExpandedBody and workEntryRawCommand from MessagesTimeline.tsx into MessagesTimeline.logic.ts and adds de-duplication logic so that identical command and detail blocks are not both rendered in the expanded tool call view.

Macroscope summarized 4610025.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Aug 13, 2026
@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 6037fdc9-d628-41d3-ab2a-02ca2af9f49c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@macroscopeapp

macroscopeapp Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved 4610025

Straightforward bug fix that prevents duplicate command details from appearing in the UI. Changes are limited to display logic, include unit tests, and have no backend/schema impact.

You can customize Macroscope's approvability policy. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant