Skip to content

fix(web): restore desktop update download progress - #6491

Open
edoedac0 wants to merge 2 commits into
pingdotgg:mainfrom
edoedac0:agent/show-desktop-update-progress
Open

fix(web): restore desktop update download progress#6491
edoedac0 wants to merge 2 commits into
pingdotgg:mainfrom
edoedac0:agent/show-desktop-update-progress

Conversation

@edoedac0

@edoedac0 edoedac0 commented Aug 13, 2026

Copy link
Copy Markdown

The compact sidebar footer replaced the old full-width update container, which removed the persistent download-progress visualization. Users could no longer tell how far an app update had downloaded without relying on transient state.

This restores that feedback within the current compact design:

  • renders download progress as an outline ring around the existing download icon
  • keeps the control hoverable while downloading so the tooltip reports the current percentage
  • normalizes progress to a bounded whole percentage shared by the ring and tooltip
  • preserves reduced-motion behavior and the existing available/downloaded states

Visual behavior

Before: the download icon sat inside a filled circular button with no visible completion indicator.

After: the button becomes a transparent outlined progress ring that fills from 0–100%, while hover text reports the matching percentage.

Verified in an isolated development client at 30% progress and at completion.

Validation

  • vp test run apps/web/src/components/desktopUpdate.logic.test.ts apps/web/src/components/sidebar/SidebarUpdatePill.test.tsx — 31 tests passed
  • vp run --filter @t3tools/web typecheck
  • targeted lint and formatting checks
  • git diff --check

Generated with GPT-5.6-Sol via the Codex harness in T3 Code.

Note

Restore desktop update download progress ring in sidebar

  • Adds SidebarUpdateDownloadProgress, a circular SVG progress ring wrapping the download icon, shown during active downloads instead of the static icon.
  • Introduces getDesktopUpdateDownloadPercent in desktopUpdate.logic.ts to produce a bounded integer percent (0–100) or null for invalid/non-downloading states.
  • Updates the downloading tooltip in getDesktopUpdateButtonTooltip to use the same bounded percent, omitting the value when downloadPercent is non-finite or absent.
  • While downloading, the sidebar button is no longer set to the native disabled state (click is still guarded), with adjusted cursor and hover styles.

Macroscope summarized ddac4c8.


Note

Low Risk
UI-only changes to the Electron sidebar update control with shared percent logic and tests; no auth, data, or backend impact.

Overview
Restores visible download progress on the compact sidebar desktop update control after the full-width update UI was removed.

Adds getDesktopUpdateDownloadPercent so the tooltip and UI share a single 0–100 floored percent (invalid or out-of-range values are clamped or omitted). getDesktopUpdateButtonTooltip now uses that helper for the “Downloading update (N%)” text.

While downloading, the pill shows SidebarUpdateDownloadProgress: a circular SVG ring around the download icon instead of a filled button with no indicator. The control stays enabled for hover (not HTML-disabled) so the percentage tooltip works, with updated styling for the transparent ring state. Tests cover the percent helper and static markup for the ring.

Reviewed by Cursor Bugbot for commit ddac4c8. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7830c54f-d6b0-4a81-b462-b8a081678ccc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Aug 13, 2026
@edoedac0
edoedac0 marked this pull request as ready for review August 13, 2026 15:59

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit aa3cec9. Configure here.

Comment thread apps/web/src/components/sidebar/SidebarUpdatePill.tsx Outdated
@macroscopeapp

macroscopeapp Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

This PR adds a visual download progress ring and modifies button disabled-state behavior during updates. While the changes are well-tested and the intent is clear (restoring download progress UI), the behavioral change to button interactivity during downloads warrants human review.

You can customize Macroscope's approvability policy. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant