fix(web): restore desktop update download progress - #6491
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit aa3cec9. Configure here.
ApprovabilityVerdict: Needs human review This PR adds a visual download progress ring and modifies button disabled-state behavior during updates. While the changes are well-tested and the intent is clear (restoring download progress UI), the behavioral change to button interactivity during downloads warrants human review. You can customize Macroscope's approvability policy. Learn more. |

The compact sidebar footer replaced the old full-width update container, which removed the persistent download-progress visualization. Users could no longer tell how far an app update had downloaded without relying on transient state.
This restores that feedback within the current compact design:
Visual behavior
Before: the download icon sat inside a filled circular button with no visible completion indicator.
After: the button becomes a transparent outlined progress ring that fills from 0–100%, while hover text reports the matching percentage.
Verified in an isolated development client at 30% progress and at completion.
Validation
vp test run apps/web/src/components/desktopUpdate.logic.test.ts apps/web/src/components/sidebar/SidebarUpdatePill.test.tsx— 31 tests passedvp run --filter @t3tools/web typecheckgit diff --checkGenerated with GPT-5.6-Sol via the Codex harness in T3 Code.
Note
Restore desktop update download progress ring in sidebar
SidebarUpdateDownloadProgress, a circular SVG progress ring wrapping the download icon, shown during active downloads instead of the static icon.getDesktopUpdateDownloadPercentindesktopUpdate.logic.tsto produce a bounded integer percent (0–100) ornullfor invalid/non-downloading states.getDesktopUpdateButtonTooltipto use the same bounded percent, omitting the value whendownloadPercentis non-finite or absent.disabledstate (click is still guarded), with adjusted cursor and hover styles.Macroscope summarized ddac4c8.
Note
Low Risk
UI-only changes to the Electron sidebar update control with shared percent logic and tests; no auth, data, or backend impact.
Overview
Restores visible download progress on the compact sidebar desktop update control after the full-width update UI was removed.
Adds
getDesktopUpdateDownloadPercentso the tooltip and UI share a single 0–100 floored percent (invalid or out-of-range values are clamped or omitted).getDesktopUpdateButtonTooltipnow uses that helper for the “Downloading update (N%)” text.While
downloading, the pill showsSidebarUpdateDownloadProgress: a circular SVG ring around the download icon instead of a filled button with no indicator. The control stays enabled for hover (not HTML-disabled) so the percentage tooltip works, with updated styling for the transparent ring state. Tests cover the percent helper and static markup for the ring.Reviewed by Cursor Bugbot for commit ddac4c8. Bugbot is set up for automated code reviews on this repo. Configure here.