Skip to content

Do not reuse name scopes built in another working directory - #7087

Open
AdzerKI wants to merge 1 commit into
phpstan:2.3.xfrom
AdzerKI:anonymous-class-names-working-directory
Open

AdzerKI wants to merge 1 commit into
phpstan:2.3.xfrom
AdzerKI:anonymous-class-names-working-directory

Conversation

@AdzerKI

@AdzerKI AdzerKI commented Nov 16, 2026

Copy link
Copy Markdown

FileTypeMapper stores anonymous classes in a file's name scopes under the names from AnonymousClassNameHelper, which hashes the path relative to the current working directory. The ftm- entry was checked against the file contents only, so a run from another directory took a map with other names, and the PHPDoc of the anonymous classes in that file resolved to nothing.

The working directory now goes into the variable key of the entry, so such a run rebuilds the map. The e2e test analyses from the project directory, clears the result cache and analyses again from src; it fails without the change.

Closes phpstan/phpstan#15752

The name scopes of a file name its anonymous classes by AnonymousClassNameHelper,
which hashes the path relative to the current working directory. The ftm- cache
entry was validated against the file contents only, so a run started from
another directory reused a map with other anonymous class names and the PHPDoc
of every anonymous class in the file resolved to nothing, even with the result
cache cleared.

The working directory is now part of the variable key of the entry.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PHPDoc of anonymous classes is lost after a run from another working directory

1 participant