Repository navigation
Conversation
The name scopes of a file name its anonymous classes by AnonymousClassNameHelper, which hashes the path relative to the current working directory. The ftm- cache entry was validated against the file contents only, so a run started from another directory reused a map with other anonymous class names and the PHPDoc of every anonymous class in the file resolved to nothing, even with the result cache cleared. The working directory is now part of the variable key of the entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FileTypeMapperstores anonymous classes in a file's name scopes under the names fromAnonymousClassNameHelper, which hashes the path relative to the current working directory. Theftm-entry was checked against the file contents only, so a run from another directory took a map with other names, and the PHPDoc of the anonymous classes in that file resolved to nothing.The working directory now goes into the variable key of the entry, so such a run rebuilds the map. The e2e test analyses from the project directory, clears the result cache and analyses again from
src; it fails without the change.Closes phpstan/phpstan#15752