Repository navigation
Count the benchmarks with the cycle collector off like bin/phpstan - #7083
Merged
Merged
Conversation
bin/phpstan calls gc_disable(), so a collection never runs in an analysis. With the collector on, what a benchmark's setup allocated decides whether a collection falls into the counted call: loading one more stub file moved NodeScopeResolverWalkBench::benchProcessStmtNodes@or-chain-32 by +15.7 % and UnionTypeBench::benchDescribeIntersections@members-256 by -18 %, and with zend.enable_gc=0 the same change moved nothing. Amp-Thread-ID: https://ampcode.com/threads/T-01a1dfe2-5bcc-770e-93fb-aeccdc327aa9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bin/phpstan calls
gc_disable(), so the cycle collector never runs in a real analysis, but the benchmarks ran with it on. With the collector on, whatever a benchmark's setup allocated decides whether a collection falls into the counted call.Example: 214333e76 loads
stubs/ext-ds-v2.stubwhen ext-ds 2 is present, as on CI. It does not touch the analysed code, yet it movedNodeScopeResolverWalkBench::benchProcessStmtNodes@or-chain-32by +12.6 % instructions and +27 % cycles, andUnionTypeBench::benchDescribeIntersections@members-256by −16 %. Locally, withzend.enable_gc=0, the same commit changes instructions, cycles, and memory by exactly 0.The expected numbers are accepted from this PR's Benchmarks run.