Keep relative links working after loading a category in place - #445
Merged
Conversation
The category browser swaps the contribution list with AJAX and rewrites the address to the category's URL, which usually sits at a different directory depth. The board's own links are relative, so the browser re-resolves all of them against the new path: from a deeper category, Board index turns into customise/community/index.php on phpbb.com and the quick links, search and FAQ shift the same way. A direct load of the category regenerates the links at the right depth, which is why only the in-place navigation breaks. Resolve the document's relative links and form actions against the address it was rendered under before the first rewrite, so they keep pointing where they did when the page loaded.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses #370 by preventing relative navigation URLs (links and form actions) from being re-resolved against a new, AJAX-updated history URL when a category is loaded in place—keeping core navigation (e.g., “Board index”) working after replaceUrl() changes the address bar.
Changes:
- Adds a pre-
replaceUrl()pass that converts certain relativehref/actionattributes to absolute URLs. - Keeps navigation behavior stable when AJAX category loading changes directory depth in the visible URL.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #370
The fix converts the page's relative links and form actions to full URLs before the address changes, so they keep working no matter what category is loaded.