-
Notifications
You must be signed in to change notification settings - Fork 30
Dev #386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TatevikGr
wants to merge
12
commits into
main
Choose a base branch
from
dev
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Dev #386
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
8d28d3b
Refactor: env (#385)
TatevikGr d24769b
feat: add default admin password configuration and update ImportDefau…
tatevikg1 4f0e4c2
fix: correct key reference in config retrieval and update embargo con…
tatevikg1 45813fe
feat: load messenger configuration and update campaign processor mess…
tatevikg1 5387bb8
fix: remove Requeued state and update allowed transitions for Suspend…
tatevikg1 314c247
feat: update database table names to remove 'phplist_' prefix and add…
tatevikg1 83a7216
feat: replace AbstractMigration with AbstractPrefixedMigration for dy…
tatevikg1 5c96486
atter review 0
tatevikg1 d3ddcbb
fix: update documentation
tatevikg1 f15e76e
docs: update AsyncEmailSending documentation and clarify failed messa…
tatevikg1 8b7f95c
feat: enhance password handling with legacy hash support and update h…
tatevikg1 c9a3b3b
feat: add support for in-memory SQLite database in test configuration
tatevikg1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,96 @@ | ||
| # This file is a "template" of what your .env file should look like. | ||
| # Set variables here that may be different on each deployment target of the app, | ||
| # e.g. development, staging, production. | ||
| # | ||
| # On `composer install`/`composer update`, this file is copied to `.env` (unless | ||
| # it already exists) and PHPLIST_SECRET is replaced with a freshly generated value. | ||
| # | ||
| # https://symfony.com/doc/current/configuration.html#configuring-environment-variables-in-env-files | ||
|
|
||
| PHPLIST_DATABASE_DRIVER=pdo_mysql | ||
| PHPLIST_DATABASE_PATH= | ||
| PHPLIST_DATABASE_HOST=127.0.0.1 | ||
| PHPLIST_DATABASE_PORT=3306 | ||
| PHPLIST_DATABASE_NAME=phplistdb | ||
| PHPLIST_DATABASE_USER=phplist | ||
| PHPLIST_DATABASE_PASSWORD=phplist | ||
| DATABASE_PREFIX=phplist_ | ||
| LIST_TABLE_PREFIX=listattr_ | ||
| PHPLIST_ADMIN_PASSWORD=admin | ||
|
|
||
| APP_DEV_VERSION=0 | ||
| APP_DEV_EMAIL=dev@dev.com | ||
| APP_POWERED_BY_PHPLIST=0 | ||
| PREFERENCEPAGE_SHOW_PRIVATE_LISTS=0 | ||
|
|
||
| API_BASE_URL=http://api.phplist.local/ | ||
| FRONT_END_BASE_URL=http://frontend.phplist.local | ||
|
|
||
| PARALLER_USE_WITH_PHPLIST3=0 | ||
|
|
||
| # Email configuration | ||
| MAILER_FROM=noreply@phplist.com | ||
| MAILER_DSN=null://null | ||
| CONFIRMATION_URL=http://api.phplist.local/api/v2/subscriber/confirm/ | ||
| SUBSCRIPTION_CONFIRMATION_URL=http://api.phplist.local/api/v2/subscription/confirm/ | ||
| PASSWORD_RESET_URL=https://example.com/reset/ | ||
| SHOW_UNSUBSCRIBELINK=1 | ||
|
|
||
| # Bounce email settings | ||
| BOUNCE_EMAIL=bounce@phplist.com | ||
| BOUNCE_IMAP_PASS=bounce@phplist.com | ||
| BOUNCE_IMAP_HOST=imap.phplist.com | ||
| BOUNCE_IMAP_PORT=993 | ||
| BOUNCE_IMAP_ENCRYPTION=ssl | ||
| BOUNCE_IMAP_MAILBOX=/var/spool/mail/bounces | ||
| BOUNCE_IMAP_MAILBOX_NAME=INBOX,ONE_MORE | ||
| BOUNCE_IMAP_PROTOCOL=imap | ||
| BOUNCE_IMAP_UNSUBSCRIBE_THRESHOLD=5 | ||
| BOUNCE_IMAP_BLACKLIST_THRESHOLD=3 | ||
| BOUNCE_IMAP_PURGE=0 | ||
| BOUNCE_IMAP_PURGE_UNPROCESSED=0 | ||
|
|
||
| # Messenger configuration for asynchronous processing | ||
| MESSENGER_TRANSPORT_DSN=doctrine://default?auto_setup=true | ||
|
|
||
| # A secret key that's used to generate certain security-related tokens | ||
| PHPLIST_SECRET=%s | ||
| VERIFY_SSL=1 | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
|
|
||
| APP_PHPLIST_ISP_CONF_PATH=/etc/phplist.conf | ||
|
|
||
| # Message sending | ||
| MAILQUEUE_BATCH_SIZE=5 | ||
| MAILQUEUE_BATCH_PERIOD=5 | ||
| MAILQUEUE_THROTTLE=5 | ||
| MESSAGING_MAX_PROCESS_TIME=600 | ||
| MAX_MAILSIZE=209715200 | ||
| DEFAULT_MESSAGEAGE=691200 | ||
| USE_MANUAL_TEXT_PART=0 | ||
| MESSAGING_BLACKLIST_GRACE_TIME=600 | ||
| GOOGLE_SENDERID= | ||
| USE_AMAZONSES=0 | ||
| USE_PRECEDENCE_HEADER=0 | ||
| EMBEDEXTERNALIMAGES=0 | ||
| EMBEDUPLOADIMAGES=0 | ||
| EXTERNALIMAGE_MAXAGE=0 | ||
| EXTERNALIMAGE_TIMEOUT=30 | ||
| EXTERNALIMAGE_MAXSIZE=204800 | ||
| FORWARD_ALTERNATIVE_CONTENT=0 | ||
| EMAILTEXTCREDITS=0 | ||
| ALWAYS_ADD_USERTRACK=1 | ||
| SEND_LISTADMIN_COPY=0 | ||
|
|
||
| FORWARD_EMAIL_PERIOD="1 minute" | ||
| FORWARD_EMAIL_COUNT=1 | ||
| FORWARD_PERSONAL_NOTE_SIZE=0 | ||
| FORWARD_FRIEND_COUNT_ATTRIBUTE= | ||
| KEEPFORWARDERATTRIBUTES=0 | ||
|
|
||
| UPLOADIMAGES_DIR=uploadimages | ||
| PHPLIST_UPLOADS_MAX_SIZE=5M | ||
|
|
||
| PUBLIC_SCHEMA=https | ||
| PHPLIST_ATTACHMENT_DOWNLOAD_URL=https://example.com/download/ | ||
| PHPLIST_ATTACHMENT_REPOSITORY_PATH=/tmp | ||
| MAX_AVATAR_SIZE=100000 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| # Optional: copy this file to ".env.test.local" to run tests against an in-memory SQLite | ||
| # database instead of MySQL, so no database server is needed for `vendor/bin/phpunit`. | ||
| # | ||
| # Note: this file is not loaded automatically by PHPUnit CLI runs (this project's ApplicationKernel | ||
| # does not read .env files on its own); either export these as real environment variables before | ||
| # running phpunit, or wire them up via your own bootstrap/CI step. | ||
|
|
||
| PHPLIST_DATABASE_DRIVER=pdo_sqlite | ||
| PHPLIST_DATABASE_PATH=:memory: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,8 +7,10 @@ This project adheres to [Semantic Versioning](https://semver.org/). | |
|
|
||
| ### Added | ||
| - Graylog integration for centralized logging (#TBD) | ||
| - `symfony/dotenv` support: configuration values are now read from a `.env` file (generated from `.env.dist` on install/update), in addition to real environment variables (#TBD) | ||
|
|
||
| ### Changed | ||
| - `config/parameters.yml.dist` no longer contains inline `env(VAR): default` fallbacks; defaults now live in `.env.dist` (#TBD) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win Use the current parameters template path. This entry names 🤖 Prompt for AI Agents |
||
|
|
||
| ### Deprecated | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,25 +1,27 @@ | ||
| # Class Documentation with PHPDoc | ||
| # Generating class documentation | ||
|
|
||
| We use [phpdoc](phpdoc.org) to automatically generate documentation for our annotated classes. | ||
| We use [phpDocumentor](https://phpdoc.org) to generate API docs from the docblocks on | ||
| our classes, properties, and methods. Output settings (title, output path) are defined | ||
| in [`phpdoc.xml`](phpdoc.xml); the generated docs are written to `docs/phpdocumentor/` | ||
| and are not committed to the repository. | ||
|
|
||
| So to be able to generate or update our class docs you would need to download and install `phpDocumentor` globally (for system wide use) as shown below: | ||
| ## Install phpDocumentor | ||
|
|
||
| 1. `cd ~` [*Optional : it's recommended to navigate to your home dir before downloading `phpDocumentor` as shown in step 2*] | ||
| 2. `wget https://phpdoc.org/phpDocumentor.phar` | ||
| 3. `chmod +x phpDocumentor.phar` | ||
| 4. `mv phpDocumentor.phar /usr/local/bin/phpDocumentor` | ||
| phpDocumentor ships as a standalone `.phar`. Install it once, globally: | ||
|
|
||
| *Possibility : In case you don't want to install `phpDocumentor` globally you can skip step 4, however you would need to run `phpDocumentor` from whatever path it was installed in.* | ||
| ```bash | ||
| wget https://phpdoc.org/phpDocumentor.phar -O /usr/local/bin/phpDocumentor | ||
| chmod +x /usr/local/bin/phpDocumentor | ||
| ``` | ||
|
|
||
| *Tip : You might need to run step four as root on some systems. That is : `sudo mv phpDocumentor.phar /usr/local/bin/phpDocumentor`* | ||
| If you'd rather not install it globally, download the `.phar` anywhere and call it | ||
| by its full path in the steps below. | ||
|
|
||
| ## Generate Docs | ||
| ## Generate the docs | ||
|
|
||
| If you did install `phpDocumentor` globally as specified above then you can generate class docs as follows. | ||
| Run : `composer run-php-documentor` | ||
| ```bash | ||
| composer run-php-documentor | ||
| ``` | ||
|
|
||
|
|
||
|
|
||
| *Note : `composer generate docs` would only work if you installed `phpDocumentor` globally, if you did not run : `custom/path/phpDocumentor -d 'src,tests' -t docs/phpdoc` to generate docs* | ||
|
|
||
| *Where `custom/path/` is the location where you downloaded `phpDocumentor`* | ||
| This runs `phpDocumentor -d 'src,tests'`, using the output path from `phpdoc.xml`. | ||
| Open `docs/phpdocumentor/index.html` in a browser to view the result. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.