Fix use-after-free of an array callable freed during validation - #23014
Open
iliaal wants to merge 1 commit into
Open
Fix use-after-free of an array callable freed during validation#23014iliaal wants to merge 1 commit into
iliaal wants to merge 1 commit into
Conversation
INIT_USER_CALL borrows the callable array from op2 without holding a reference. Validating a compound [$obj, "Class::method"] callable emits an E_DEPRECATED that reaches a user error handler, which can drop the array's last reference; the receiver taken from element 0 is then released before the call frame is built, and the method body runs with $this pointing at freed memory. Hold the array across validation and the frame build, as the closure case in the same handler already does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INIT_USER_CALLreads the callable array from op2 without holding a reference, so an error handler reached by the compound-callable deprecation can free the receiver before the call frame is built.array_map()and friends are unaffected: the callable arrives as an argument, so the frame holds a reference for the call.Unlike #22881 the hold belongs in the VM here. The reference has to outlive
zend_is_callable_at_frame(), since releasing it there drops the receiver before theGC_ADDREFa few lines below.