Repository navigation
feat: go watcher - #2716
Closed
AlliBalliBaba wants to merge 19 commits into
Closed
feat: go watcher#2716AlliBalliBaba wants to merge 19 commits into
AlliBalliBaba wants to merge 19 commits into
Conversation
Contributor
Author
|
I'll first have to verify the tradeoffs of using this watcher. But yeah we can add an exclusion pattern. I think #2572 might have already been fixed on main, haven't tried it myself. Moving the watcher to go would also fix #2708 (and hopefully not introduce other issues...). #2568 is an issue in the pecl HTTP extension and needs a fix there (not thread safe on shutdown). |
Contributor
Author
|
Nvm, I had big hopes for sgtdi/fswatcher, but I couldn't get it to not crash CI or leak memory on Linux. Let's wait for a better go watcher implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an experimental branch, moving the watcher to a go-only library (https://github.com/sgtdi/fswatcher).
Not sure if worth it yet, but would potentially simplify dependencies (like not needing libstdc++).