Repository navigation
fix: default max_consecutive_failures to 6 for Caddy workers - #2704
Merged
Merged
Conversation
toWorkerOptions always passed MaxConsecutiveFailures to WithWorkerMaxFailures, so an unset value overrode the documented default of 6 with 0 and any Caddyfile or JSON worker aborted startup on its first boot failure. The field is now a pointer, so the default applies when it is omitted and an explicit 0 still means no retries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs and the field comment say
max_consecutive_failuresdefaults to 6. However,toWorkerOptions()always passedwc.MaxConsecutiveFailurestoWithWorkerMaxFailures(). When the directive is not set, its zero value overrode the default, so every Caddyfile or JSON worker aborted startup on its first boot failure instead of retrying with backoff.The field is now a
*int, the same wayRequestBodyTimeoutis handled. The option is only passed when the directive is set: the default applies when it is omitted, and an explicit0still means "no retries".Found while investigating #2697. The new test fails on
mainwith "too many consecutive failures" and passes with the fix.