Repository navigation
Narrow return type of wp_get_development_mode - #500
Merged
szepeviktor merged 1 commit intoNov 1, 2026
Merged
szepeviktor merged 1 commit into
szepeviktor merged 1 commit into
Conversation
wp_get_development_mode() reads WP_DEVELOPMENT_MODE and checks it against a fixed list. Any other value becomes ''. The static cache is set only after this check. There is no filter. The function therefore always returns '', 'all', 'core', 'plugin' or 'theme'.
s-a-s-k-i-a
marked this pull request as ready for review
November 1, 2026 11:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wp_get_development_mode()only returns one of five values:'','all','core','plugin'or'theme'. WordPress checksWP_DEVELOPMENT_MODEagainst this fixed list and falls back to''for anything else. There is no filter.The stubs still say
string. This PR adds the five values tofunctionMap.php, the same way #296 did forwp_get_server_protocol().phpstan-wordpress already tells users to call
wp_get_development_mode()instead of reading the constant. With this change, PHPStan reports a typo likewp_get_development_mode() === 'themes'as always false.Changes
functionMap.php: new entry forwp_get_development_mode.wordpress-stubs.php: regenerated with./generate.sh.tests/data/return/wp-get-development-mode.php: new return type test.Testing
composer run testpasses locally on PHP 8.2, 8.4 and 8.5.IntegrateandSpellingworkflows pass on my fork.AI-assisted (Claude). I reviewed and tested the change.