fix(dump): format the dump card time from the epoch milliseconds Dump Row already holds. - #73
Conversation
…Row already holds.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (20)
🧰 Additional context used🪛 PHPMD (2.15.0)tests/Storage/SnapshotStoreTest.php[warning] 19-1622: The class SnapshotStoreTest has 1604 lines of code. Current threshold is 1000. Avoid really long classes. (undefined) (ExcessiveClassLength) [warning] 19-1622: The class SnapshotStoreTest has 55 public methods and attributes. Consider reducing the number of public items to less than 45. (undefined) (ExcessivePublicCount) [warning] 19-1622: The class SnapshotStoreTest has 59 non-getter- and setter-methods. Consider refactoring SnapshotStoreTest to keep number of methods under 25. (undefined) (TooManyMethods) [warning] 19-1622: The class SnapshotStoreTest has 55 public methods. Consider refactoring SnapshotStoreTest to keep number of public methods under 10. (undefined) (TooManyPublicMethods) [warning] 19-1622: The class SnapshotStoreTest has an overall complexity of 76 which is very high. The configured complexity threshold is 50. (undefined) (ExcessiveClassComplexity) src/Panel/Dump/DumpCardRenderer.php[error] 93-93: Avoid using static access to class '\PHPForge\Debug\Helper\Format' in method 'formatTime'. (undefined) (StaticAccess) tests/Panel/Dump/DumpCardRendererTest.php[warning] 19-750: The class DumpCardRendererTest has 31 non-getter- and setter-methods. Consider refactoring DumpCardRendererTest to keep number of methods under 25. (undefined) (TooManyMethods) [warning] 19-750: The class DumpCardRendererTest has 29 public methods. Consider refactoring DumpCardRendererTest to keep number of public methods under 10. (undefined) (TooManyPublicMethods) [error] 148-152: Avoid using static access to class '\PHPForge\Debug\Panel\Dump\DumpCardRenderer' in method 'testRenderMessageCellFormatsMillisecondsAtTheUpperBoundary'. (undefined) (StaticAccess) [error] 213-217: Avoid using static access to class '\PHPForge\Debug\Panel\Dump\DumpCardRenderer' in method 'testRenderMessageCellKeepsTimeAndTraceMetadataTogether'. (undefined) (StaticAccess) [error] 420-424: Avoid using static access to class '\PHPForge\Debug\Panel\Dump\DumpCardRenderer' in method 'testRenderMessageCellRendersFormattedTimeWhenTimeIsPositive'. (undefined) (StaticAccess) 🔇 Additional comments (3)
📝 SummarySummary by CodeRabbit
WalkthroughDump timestamps are formatted as epoch milliseconds. Permission-dependent snapshot storage tests are marked as Linux-only with a PHPUnit attribute. ChangesDump timestamp formatting
Snapshot storage test platform annotations
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to Dump timestamps now use the row’s documented millisecond units, and permission-sensitive storage tests are limited to Linux. The supplied evidence establishes no concrete user-impacting or workflow-blocking regression. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the clock’s new scale, Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #73 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 2391 2391
===========================================
Files 173 173
Lines 8723 8723
===========================================
Hits 8723 8723 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
1 participant
Pull Request
Related Issues