Skip to content

refactor(ui): delete the unused User, dropdown/collapse and never-emitted CSS, style the gauge readout and the Profiling nesting arrows, and move the Request panel rules to request.css. - #71

Merged
terabytesoftw merged 1 commit into
mainfrom
refactor/phase-4-ui-renderers
Sep 25, 2026

Conversation

@terabytesoftw

Copy link
Copy Markdown
Contributor

Pull Request

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bugfix (non-breaking change that fixes an issue)
  • CI/build configuration
  • Documentation update
  • New feature (non-breaking change that adds functionality)
  • Refactoring (no functional changes)

…tted CSS, style the gauge readout and the Profiling nesting arrows, and move the Request panel rules to `request.css`.
@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: f4625d7e-ba9d-47af-bec0-3991c25e598f

📥 Commits

Reviewing files that changed from the base of the PR and between da38998 and 2b504ff.

⛔ Files ignored due to path filters (3)
  • resources/assets/dist/css/debug.min.css is excluded by !**/dist/**, !**/*.min.css
  • resources/assets/dist/js/debug.min.js is excluded by !**/dist/**, !**/*.min.js
  • resources/assets/dist/js/focus.min.js is excluded by !**/dist/**, !**/*.min.js
📒 Files selected for processing (13)
  • e2e/history-layout.spec.js
  • resources/src/core/debug.js
  • resources/src/core/disclosure.js
  • resources/src/styles/main.css
  • resources/src/styles/primitives.css
  • resources/src/styles/request.css
  • resources/src/toolbar/focus.js
  • resources/tests/debug-bootstrap.test.js
  • resources/tests/debug-disclosure.test.js
  • resources/tests/debug-dropdown.test.js
  • resources/tests/toolbar-runtime.test.js
  • tools/quality/asset-size-budget.json
  • tools/quality/css-vocabulary-allowlist.json
💤 Files with no reviewable changes (4)
  • resources/src/styles/primitives.css
  • resources/tests/debug-dropdown.test.js
  • tools/quality/css-vocabulary-allowlist.json
  • resources/tests/debug-disclosure.test.js

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (23)
  • GitHub Check: composer-require-checker / PHP 8.5-ubuntu-latest
  • GitHub Check: security / Zizmor (ubuntu-latest)
  • GitHub Check: quality / Spelling (ubuntu-latest)
  • GitHub Check: quality / YAML (ubuntu-latest)
  • GitHub Check: quality / Actionlint (ubuntu-latest)
  • GitHub Check: quality / EditorConfig (ubuntu-latest)
  • GitHub Check: quality / Markdown (ubuntu-latest)
  • GitHub Check: phpunit / PHP 8.3-windows-2022
  • GitHub Check: phpunit / PHP 8.4-windows-2022
  • GitHub Check: phpunit / PHP 8.4-ubuntu-latest
  • GitHub Check: phpunit / PHP 8.5-ubuntu-latest
  • GitHub Check: phpunit / PHP 8.5-windows-2022
  • GitHub Check: mutation / PHP 8.5-ubuntu-latest
  • GitHub Check: phpunit / PHP 8.3-ubuntu-latest
  • GitHub Check: phpstan / PHP 8.5-ubuntu-latest
  • GitHub Check: easy-coding-standard / PHP 8.5-ubuntu-latest
  • GitHub Check: Verify Vite build reproduces dist.
  • GitHub Check: Analyze (actions)
  • GitHub Check: phpunit / PHP 8.4-windows-2022
  • GitHub Check: phpunit / PHP 8.3-windows-2022
  • GitHub Check: phpunit / PHP 8.5-windows-2022
  • GitHub Check: mutation / PHP 8.5-ubuntu-latest
  • GitHub Check: Verify Vite build reproduces dist.
🔇 Additional comments (8)
resources/src/styles/request.css (1)

1-614: LGTM!

e2e/history-layout.spec.js (1)

149-186: LGTM!

resources/src/core/disclosure.js (1)

49-49: LGTM!

Also applies to: 53-53, 57-58, 60-60, 64-66

tools/quality/asset-size-budget.json (1)

8-9: LGTM!

Also applies to: 44-45

resources/src/toolbar/focus.js (1)

72-72: LGTM!

resources/src/core/debug.js (1)

70-70: LGTM!

resources/tests/debug-bootstrap.test.js (1)

5-5: LGTM!

Also applies to: 235-255, 257-265, 267-278

resources/tests/toolbar-runtime.test.js (1)

494-494: LGTM!

Also applies to: 511-511


📝 Summary

Summary by CodeRabbit

  • New Features
    • Request panels now use clearer layouts for overviews, diagnostics, server variables, and route traces, adapting to narrower screens.
  • Bug Fixes
    • Pressing Escape in an embedded debug toolbar now requests that its parent close the toolbar drawer. Standalone pages and unrelated key presses do not trigger that request.
  • Behavior Changes
    • Debug toolbar dropdown and collapse controls no longer respond to the previously supported click and keyboard interactions.

Walkthrough

The changes add request-panel styles, adjust debugger disclosure and Escape handling, and add Yii3 History sort-marker tests.

Changes

Debugger control behavior

Layer / File(s) Summary
Disclosure controls and removed dropdown handling
resources/src/core/disclosure.js, resources/src/styles/primitives.css, resources/tests/debug-disclosure.test.js, resources/tests/debug-dropdown.test.js, tools/quality/css-vocabulary-allowlist.json, tools/quality/asset-size-budget.json
The disclosure module now handles cell-more controls and no longer contains dropdown or collapse handling. Collapse and dropdown tests were removed. The coarse-pointer target-size selector and CSS vocabulary entries changed, and the CSS asset limits decreased.
Escape requests parent drawer closure
resources/src/core/debug.js, resources/src/toolbar/focus.js, resources/tests/debug-bootstrap.test.js, resources/tests/toolbar-runtime.test.js, tools/quality/asset-size-budget.json
Escape handling no longer defers to dropdown state before requesting parent-toolbar drawer closure. Tests cover embedded and standalone pages, ignored document-targeted events, and rejected closure requests. The JavaScript asset limits decreased.

Request-panel styles

Layer / File(s) Summary
Request overview and tabs
resources/src/styles/request.css
Styles cover request identity, metadata, status, metrics, configuration tags, routing errors, and request tabs.
Diagnostic ledgers and responsive layouts
resources/src/styles/request.css
Styles cover diagnostic headers, filters, header lanes, key/value rows, server groups, disclosure controls, and hidden states. Container queries stack lanes and rows at the specified widths.
Route-resolution trace
resources/src/styles/request.css
Styles set spacing and text rules for route-resolution messages and sizing and alignment rules for the trace table.

Yii3 History sort-marker tests

Layer / File(s) Summary
Ascending and descending header cases
e2e/history-layout.spec.js
End-to-end tests check the arrow for ascending and descending sort states and verify that unsorted headers have no generated marker.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Refactor

Merge Risk: ⚪ Minimal · up to 2b504

The removed handlers served no current controls, and the request-panel styles are shipped. No actionable merge-blocking risk remains after normal checks.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 60.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 6 files. (2 skipped: 2… Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the UI refactor, including removal of unused UI and CSS, styling updates, and moving Request panel rules to request.css. It is specific and related to the stated objective…
Description check ✅ Passed The description identifies the change as a refactoring with no functional changes. This matches the pull request objectives and changeset.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 60.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 6 files. (2 skipped: 2 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit taps Escape with care,
The drawer hears the message there.
Request rows stack when screens grow small,
History arrows mark the sort for all.
I nibble greens and hop away,
Glad to celebrate this change today.

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Sep 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (da38998) to head (2b504ff).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##                main       #71   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity      2391      2391           
===========================================
  Files            173       173           
  Lines           8723      8723           
===========================================
  Hits            8723      8723           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@terabytesoftw
terabytesoftw merged commit 8f9a8b7 into main Sep 25, 2026
43 checks passed
@terabytesoftw
terabytesoftw deleted the refactor/phase-4-ui-renderers branch September 25, 2026 13:56
@terabytesoftw terabytesoftw added the bug Something isn't working label Sep 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant