Repository navigation
fix(field): keep server validation message on the form control - #648
Merged
Merged
Conversation
displayValidationMessage() used setErrors() to put the server-side
validatemessage on the FormControl. setErrors() is a one-off override,
so any later updateValueAndValidity() call wiped it out. That happens
when the base or subclass setValue() runs after
updateComponentCommonProperties(), and when the [formControl] or
[required] directives set up or change. It used to work only because
setErrors() was wrapped in setTimeout(100).
Add a validator to fieldControl that returns { message: true } while
angularPConnectData.validateMessage is set, then re-run validation.
The error is now re-applied every time validation runs and clears on
its own when the message goes away. <mat-error> shows reliably without
the timeout.
The validator is attached in displayValidationMessage() because some
subclasses create their own fieldControl.
tammy-a11y
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
displayValidationMessage() used setErrors() to put the server-side validatemessage on the FormControl. setErrors() is a one-off override, so any later updateValueAndValidity() call wiped it out. That happens when the base or subclass setValue() runs after
updateComponentCommonProperties(), and when the [formControl] or [required] directives set up or change. It used to work only because setErrors() was wrapped in setTimeout(100).
Add a validator to fieldControl that returns { message: true } while angularPConnectData.validateMessage is set, then re-run validation. The error is now re-applied every time validation runs and clears on its own when the message goes away. shows reliably without the timeout.
The validator is attached in displayValidationMessage() because some subclasses create their own fieldControl.
(EA-D17238)