fix(user.js): apply lifecycle markers to executor-surfaced stragglers - #313
Draft
netravnen wants to merge 1 commit into
Draft
fix(user.js): apply lifecycle markers to executor-surfaced stragglers#313netravnen wants to merge 1 commit into
netravnen wants to merge 1 commit into
Conversation
netravnen
changed the title
netravnen
force-pushed
the
fix/lifecycle-marker-stragglers
branch
from
August 20, 2026 20:19
0b4ee29 to
34d62f7
Compare
Resolve the executor-surfaced-decisions ticket (2026-08-20): the wave-1 conformance tests found zero-reference symbols and one @ai duplication group that no human audit had caught. Per the ratified decisions, the four orphan helpers are staged rather than deleted, the two dead documented logging helpers are marked deprecated ahead of their allowlisted removal, and the triplicated modal-close @ai tag is rewritten so each site names its own modal and the loop its cancel protects. Changes: - CP CONFLICT_RESOLVE_GATE_COUNT: line-comment "@StaGeD wip" marker (gate-count for data-driven conflict-resolver gate reporting; verifyConflictGates hardcodes the count in prose today). - CP addToolbarDropdownAction: "@StaGeD wip" (no multi-item toolbar dropdown built yet; wire when the first one lands). - CP getCopyNetworkFrontendPath: "@StaGeD wip" (per-entity copy-URL helper; wire when the copy-link action expands beyond networks). - DP stripTrailingLinkEmojiTokens: "@StaGeD wip" (anchor-label emoji cleanup; wire into hydrateExistingPeeringDbAnchor when label rewriting returns). - lib/admincom-common.js dbgGroup/dbgGroupEnd: "@deprecated" with removal condition (documented logging API with no callers; remove with the next CONVENTIONS.md doc cycle). - CP: the three identical "@ai Preserve the cancelSignal write and the resolveClosed() call." tags on modal close() handlers rewritten modal-specifically (IXLAN renumber / IX-F member audit / conflict resolver), each naming the apply/merge/delete loop its cancelSignal write aborts. Each rewritten tag is unique and passes the litmus. - Version bumps (lib change inlines into all three scripts): CP 2.0.228 -> 2.0.229, DP 1.7.12 -> 1.7.13, FP 1.1.42 -> 1.1.43, in both .src.js and .meta.js; .user.js regenerated. Security: - N/A Testing: - python user.js/scripts/build_userscripts.py && --check: green. - node --check on all three generated .user.js: green. - cd user.js && node --test: 585 pass, 1 skipped, 0 fail. Backwards Compatibility: - Comment-only and version-header changes; no behavior change. Assisted-by: Claude:claude-opus-5
netravnen
force-pushed
the
fix/lifecycle-marker-stragglers
branch
from
August 20, 2026 20:40
34d62f7 to
5dbba27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack created with GitHub Stacks CLI • Give Feedback 💬