fix(cp): remove the tautological API-coverage self-check - #310
Draft
netravnen wants to merge 1 commit into
Draft
Conversation
netravnen
force-pushed
the
fix/cp-remove-tautological-selfcheck
branch
from
August 20, 2026 14:02
84da639 to
cf07dbb
Compare
netravnen
force-pushed
the
fix/cp-remove-tautological-selfcheck
branch
2 times, most recently
from
August 20, 2026 20:01
26c82c0 to
a44be00
Compare
netravnen
force-pushed
the
fix/cp-remove-tautological-selfcheck
branch
from
August 20, 2026 20:14
a44be00 to
a794897
Compare
runApiResourceCoverageCheck validated ENTITY_API_RESOURCE_MAP's slugs against OPENAPI_KNOWN_RESOURCE_SLUGS -- a set built from ENTITY_API_RESOURCE_MAP itself, so the check could never fire while reporting green in debug mode. A guard that cannot fire but reports success is worse than no guard: it manufactures false confidence. A real coverage check needs an independent source of truth (a fetched OpenAPI spec); until one exists, no check is honest, and a note on the map says so. Also removes the dead keeperRowForDelete variable in the conflict-resolver apply loop, assigned twice and never read. Changes: - Delete runApiResourceCoverageCheck, OPENAPI_KNOWN_RESOURCE_SLUGS and the runSelfCheck call site. - Add a note on ENTITY_API_RESOURCE_MAP explaining why there is no self-check and what a real one requires. - Delete the two dead keeperRowForDelete assignments in the IX-F conflict-resolver apply loop (the DELETE targets item.doomedRow.id; the keeper read-back result was never consumed via this variable). - Bump CP @Version to 2.0.228 (src + meta); regenerate .user.js. Security: - N/A (the removed check never guarded anything -- it was structurally unable to fail). Testing: - Full suite green: 585 pass, 0 fail (includes the IX-F merge-apply suite, which pins the conflict-resolver write path this touches). - build --check and node --check on the regenerated .user.js: clean. - Verified by grep that zero references remain to the deleted symbols. Backwards Compatibility: - Debug mode no longer logs the meaningless "api resource coverage ok" self-check line; no other observable change. Assisted-by: Claude:claude-opus-5
netravnen
force-pushed
the
fix/cp-remove-tautological-selfcheck
branch
from
August 20, 2026 20:40
a794897 to
2c19607
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
runApiResourceCoverageCheck validated ENTITY_API_RESOURCE_MAP's slugs
against OPENAPI_KNOWN_RESOURCE_SLUGS -- a set built from
ENTITY_API_RESOURCE_MAP itself, so the check could never fire while
reporting green in debug mode. A guard that cannot fire but reports
success is worse than no guard: it manufactures false confidence. A
real coverage check needs an independent source of truth (a fetched
OpenAPI spec); until one exists, no check is honest, and a note on the
map says so. Also removes the dead keeperRowForDelete variable in the
conflict-resolver apply loop, assigned twice and never read.
Changes:
the runSelfCheck call site.
self-check and what a real one requires.
conflict-resolver apply loop (the DELETE targets item.doomedRow.id;
the keeper read-back result was never consumed via this variable).
Security:
unable to fail).
Testing:
suite, which pins the conflict-resolver write path this touches).
Backwards Compatibility:
self-check line; no other observable change.
Assisted-by: Claude:claude-opus-5
Stack created with GitHub Stacks CLI • Give Feedback 💬