Skip to content

fix(cp): remove the tautological API-coverage self-check - #310

Draft
netravnen wants to merge 1 commit into
fix/fp-lifecycle-markersfrom
fix/cp-remove-tautological-selfcheck
Draft

fix(cp): remove the tautological API-coverage self-check#310
netravnen wants to merge 1 commit into
fix/fp-lifecycle-markersfrom
fix/cp-remove-tautological-selfcheck

Conversation

@netravnen

@netravnen netravnen commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

runApiResourceCoverageCheck validated ENTITY_API_RESOURCE_MAP's slugs
against OPENAPI_KNOWN_RESOURCE_SLUGS -- a set built from
ENTITY_API_RESOURCE_MAP itself, so the check could never fire while
reporting green in debug mode. A guard that cannot fire but reports
success is worse than no guard: it manufactures false confidence. A
real coverage check needs an independent source of truth (a fetched
OpenAPI spec); until one exists, no check is honest, and a note on the
map says so. Also removes the dead keeperRowForDelete variable in the
conflict-resolver apply loop, assigned twice and never read.

Changes:

  • Delete runApiResourceCoverageCheck, OPENAPI_KNOWN_RESOURCE_SLUGS and
    the runSelfCheck call site.
  • Add a note on ENTITY_API_RESOURCE_MAP explaining why there is no
    self-check and what a real one requires.
  • Delete the two dead keeperRowForDelete assignments in the IX-F
    conflict-resolver apply loop (the DELETE targets item.doomedRow.id;
    the keeper read-back result was never consumed via this variable).
  • Bump CP @Version to 2.0.228 (src + meta); regenerate .user.js.

Security:

  • N/A (the removed check never guarded anything -- it was structurally
    unable to fail).

Testing:

  • Full suite green: 585 pass, 0 fail (includes the IX-F merge-apply
    suite, which pins the conflict-resolver write path this touches).
  • build --check and node --check on the regenerated .user.js: clean.
  • Verified by grep that zero references remain to the deleted symbols.

Backwards Compatibility:

  • Debug mode no longer logs the meaningless "api resource coverage ok"
    self-check line; no other observable change.

Assisted-by: Claude:claude-opus-5


Stack created with GitHub Stacks CLIGive Feedback 💬

@netravnen
netravnen force-pushed the fix/cp-remove-tautological-selfcheck branch from 84da639 to cf07dbb Compare August 20, 2026 14:02
@netravnen
netravnen force-pushed the fix/cp-remove-tautological-selfcheck branch 2 times, most recently from 26c82c0 to a44be00 Compare August 20, 2026 20:01
@netravnen
netravnen force-pushed the fix/cp-remove-tautological-selfcheck branch from a44be00 to a794897 Compare August 20, 2026 20:14
runApiResourceCoverageCheck validated ENTITY_API_RESOURCE_MAP's slugs
against OPENAPI_KNOWN_RESOURCE_SLUGS -- a set built from
ENTITY_API_RESOURCE_MAP itself, so the check could never fire while
reporting green in debug mode. A guard that cannot fire but reports
success is worse than no guard: it manufactures false confidence. A
real coverage check needs an independent source of truth (a fetched
OpenAPI spec); until one exists, no check is honest, and a note on the
map says so. Also removes the dead keeperRowForDelete variable in the
conflict-resolver apply loop, assigned twice and never read.

Changes:
- Delete runApiResourceCoverageCheck, OPENAPI_KNOWN_RESOURCE_SLUGS and
  the runSelfCheck call site.
- Add a note on ENTITY_API_RESOURCE_MAP explaining why there is no
  self-check and what a real one requires.
- Delete the two dead keeperRowForDelete assignments in the IX-F
  conflict-resolver apply loop (the DELETE targets item.doomedRow.id;
  the keeper read-back result was never consumed via this variable).
- Bump CP @Version to 2.0.228 (src + meta); regenerate .user.js.

Security:
- N/A (the removed check never guarded anything -- it was structurally
  unable to fail).

Testing:
- Full suite green: 585 pass, 0 fail (includes the IX-F merge-apply
  suite, which pins the conflict-resolver write path this touches).
- build --check and node --check on the regenerated .user.js: clean.
- Verified by grep that zero references remain to the deleted symbols.

Backwards Compatibility:
- Debug mode no longer logs the meaningless "api resource coverage ok"
  self-check line; no other observable change.

Assisted-by: Claude:claude-opus-5
@netravnen
netravnen force-pushed the fix/cp-remove-tautological-selfcheck branch from a794897 to 2c19607 Compare August 20, 2026 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant