Repository navigation
馃悰 Enforcing the waitForGeneration timeout on in-flight polls and retries - #18
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
waitForGenerationdocumentstimeoutas a total budget, but it was only checked between polls. A slowget()(and its internal retries) could run past it: a late success resolved, and a late pending response only reported the timeout once it came back.Changes
AbortController, composed with the caller'ssignaland passed to every poll and to the sleep between polls. When it fires, the in-flight request is aborted and the call rejects with the usual "timed out" error.