✨ Adding workspace filter to snippets/folders list and listAll() via page=all - #11
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gaps raised while building the CLI.
Changes
snippets.list()andtemplateFolders.list()now requireworkspace_id(sent asq[workspace_id]). The backend appliesWorkspaceOrNoneFilter, so without it these calls always returned an empty list.listAll()on workspaces, document templates, snippets and template folders: one request withpage=all, returns a plainT[]. Backed by a newfetchAllhelper inpagination.ts, since apage=allresponse carries nometaandfetchPagewould reject it.listAll(): their optimized index does not honorpage=all.Notes
Making
workspace_idrequired is a type-level change, released as minor because calls without it never returned data.Tests
pnpm test(204 passing),pnpm lint,tsc --noEmit.