Raise CaptionReadSyntaxError for malformed SRT instead of IndexError - #419
Merged
Conversation
Contributor
|
Thanks for the fix — this looks good! One small thing before we merge: could you rebase onto the latest |
eeshsaxena
force-pushed
the
srt-malformed-read-error
branch
2 times, most recently
from
August 18, 2026 08:02
2689d72 to
3cd759e
Compare
Author
|
@OlteanuRares thanks for the review. Done: rebased onto the latest |
SRTReader.read leaked a raw IndexError or ValueError on a few kinds of malformed input: a caption number with no timing line after it, a timing line with no --> arrow, or a timestamp with missing or non-numeric fields. read() is meant to raise the CaptionRead* errors, so callers catching those got an unexpected crash instead. Guard the timing line and wrap the timestamp parsing so these surface as CaptionReadSyntaxError, matching the other readers.
SRTReader().detect("1") crashed with IndexError because it accessed
lines[1] without checking there were at least two lines. Return False
early when content has fewer than two lines.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
OlteanuRares
force-pushed
the
srt-malformed-read-error
branch
from
August 18, 2026 09:59
3cd759e to
9fb9cd0
Compare
Contributor
|
Thanks for the rebase! I went ahead and pushed two small changes directly to your branch:
All 24 SRT tests pass. Merging now — thanks for the contribution! |
OlteanuRares
approved these changes
Aug 18, 2026
panasicov
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SRTReader().read()leaks a bareIndexError(orValueError) on a few kinds of malformed SRT, rather than one of theCaptionRead*errors callers expect to catch:The first is a caption number with no timing line after it, the second a non-numeric timestamp. A timing line missing the
-->arrow, or a stamp with too few fields, hit the same paths. I guarded the timing-line lookup and wrapped the timestamp parsing so they raiseCaptionReadSyntaxErrorlike the other readers do. Added a parametrized test for the malformed cases; full suite still passes.