Skip to content

fix: respect initial filters when array - #672

Merged
katarinazaprazna merged 1 commit into
patternfly:mainfrom
PeterYurkovich:respect-array-initial-values
Nov 18, 2026
Merged

katarinazaprazna merged 1 commit into
patternfly:mainfrom
PeterYurkovich:respect-array-initial-values

Conversation

@PeterYurkovich

Copy link
Copy Markdown
Contributor

Resolves #671

Due to searchParams.getAll returning an empty array when the URL doesn't contain the url param, the truthy check on urlValue will evaluate to truthy even when it should be evaluated to false. This PR adjusts the determination of if initialFilters should be used based on if isArrayFilter is true. It also adds a test to prevent future regressions

@katarinazaprazna katarinazaprazna left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@katarinazaprazna
katarinazaprazna merged commit 334d7ec into patternfly:main Nov 18, 2026
5 checks passed
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 6.7.0-prerelease.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Initial Filters is not respected when array type filter

2 participants