Skip to content

fix(CI): exclude private packages from prerelease versioning - #12724

Merged
rebeccaalpert merged 1 commit into
patternfly:mainfrom
gabipodolnikova:FELT-143-prerelease-private-tag-fix
Nov 19, 2026
Merged

rebeccaalpert merged 1 commit into
patternfly:mainfrom
gabipodolnikova:FELT-143-prerelease-private-tag-fix

Conversation

@gabipodolnikova

@gabipodolnikova gabipodolnikova commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

What: Fixes the prerelease preparation failure after #12694, as part of FELT-143.

Lerna attempted to create demo-app-ts@6.5.0-prerelease.139, which already exists from a Felt release. Add --no-private to prerelease versioning so private integration/demo packages do not create release tags. Update the regression test to require the flag.

Validation

  • Reproduced the collision in a disposable clone with Git commit/tag creation intercepted.
  • Confirmed --no-private avoids the collision while selecting all 10 public React packages.
  • All 26 automation tests, ESLint, Prettier, and diff checks passed.

Additional issues: The failed release stopped before pushing release updates or publishing to npm. No existing tags are deleted or moved. Stable Promote remains disabled and unchanged.

Summary by CodeRabbit

  • Chores
    • Private packages are now excluded from prerelease versioning.
  • Tests
    • Updated release checks to reflect the prerelease versioning behavior.

@coderabbitai

coderabbitai Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The prerelease preparation command now passes --no-private to Lerna. The corresponding test expects this option.

Changes

Prerelease versioning

Layer / File(s) Summary
Update prerelease version command
.github/prepare-release.mjs, .github/release.test.mjs
The Lerna prerelease version command includes --no-private. The test expects the updated arguments.

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Possibly related PRs

Suggested reviewers: kmcfaul, rebeccaalpert

Merge Risk: Minimal · up to f7080

Prerelease versioning now skips private integration and demo packages, which avoids the tag collision that broke prerelease preparation. No actionable merge risk was found.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the main change: private packages are excluded from prerelease versioning through the Lerna command. The raw summary confirms that --no-private was added to the prerelease versioning…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: private packages are excluded from prerelease versioning through the Lerna command. The raw summary confirms that --no-private was added to the prerelease versioning command in .github/prepare-release.mjs, and the test was updated to match. The 'fix(CI)' prefix fits the release-workflow fix described in the objectives.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ee95526a-b755-40b2-af8d-467dca98580b
Commits

Reviewing files that changed from the base of the PR and between c8027b3 and f7080ac.

Files selected for processing: 2

  • .github/prepare-release.mjs
  • .github/release.test.mjs

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

@patternfly-build

patternfly-build commented Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator

@rebeccaalpert
rebeccaalpert merged commit c61d646 into patternfly:main Nov 19, 2026
16 checks passed
@patternfly-build

Copy link
Copy Markdown
Collaborator

Your changes have been released in: - @patternfly/react-charts@8.7.1-prerelease.0

  • @patternfly/react-code-editor@6.7.1-prerelease.1
  • @patternfly/react-core@6.7.1-prerelease.1
  • @patternfly/react-docs@7.7.1-prerelease.1
  • @patternfly/react-drag-drop@6.7.1-prerelease.1
  • @patternfly/react-icons@6.7.1-prerelease.0
  • @patternfly/react-styles@6.7.1-prerelease.0
  • @patternfly/react-table@6.7.1-prerelease.1
  • @patternfly/react-templates@6.7.1-prerelease.1
  • @patternfly/react-tokens@6.7.1-prerelease.0

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants