Repository navigation
Mask GX matrix indices to six bits - #376
Conversation
|
Caution Review failedThe pull request is closed. Walkthrough
Merge Risk:
|
There was a problem hiding this comment.
🔇 Additional comments: 1
aurora-main-1-1: 1
1-1:Minor · Potential issue · Quick win
⚠️ Unverified finding
We couldn't verify this from the code. It is shown for review, not as a verified issue.The new Aurora commit may change a CMake dependency pin without a corresponding update to
Launcher/Prepare-Dependencies.ps1, whose pins are asserted against Aurora’s declarations.Dependency preparation fails, preventing an installer build.
This can occur when: Preparing installer dependencies after checking out the new submodule commit, if one of its declared dependency pins differs from the script’s pin.

Review info
-
Run configuration-
- Source mode: Auto
- Repository: Unavailable
- Branch: Unavailable
- File: No configuration file from this repository applied
- Commit: Unavailable
- Layers: defaults
- Review profile: CHILL
- Plan: Advanced
- Run ID:
8ac84502-62a3-4e52-a16a-f0849b0c137c
Files selected for processing: 1-
aurora-main
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
-
|
The bump only changes lib/gx/shader.cpp and lib/gx/command_processor.cpp (457903b..4aa0141), so no CMake dependency pins move. |
Bumps aurora so per-vertex position and texture matrix indices use only their low six bits, matching Dolphin (patchzyy/aurora-wiicompiled#7).
Summary by CodeRabbit