Skip to content

Mask GX matrix indices to six bits - #376

Merged
patchzyy merged 2 commits into
mainfrom
bump-aurora-mtxidx
Oct 29, 2026
Merged

patchzyy merged 2 commits into
mainfrom
bump-aurora-mtxidx

Conversation

@patchzyy

@patchzyy patchzyy commented Oct 29, 2026 •

Copy link
Copy Markdown
Owner

Bumps aurora so per-vertex position and texture matrix indices use only their low six bits, matching Dolphin (patchzyy/aurora-wiicompiled#7).

Summary by CodeRabbit

  • Chores
    • Updated the included Aurora component. The available change summary does not specify any user-visible changes, so no additional feature or fix is noted.

@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Caution

Review failed

The pull request is closed.

Walkthrough

The aurora-main subproject reference changed from commit 457903be449932bf7f065bb1c8d544ee296c7cbd to 4aa01413e07def31ce3e0906b6245ccd994d6a55.

Changes: Aurora reference

Layer / File(s) Summary
Update subproject reference
aurora-main
The aurora-main reference now points to commit 4aa01413e07def31ce3e0906b6245ccd994d6a55.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Suggested reviewers: theofficialgman

Merge Risk: Minimal · previous review b4d4c

The Aurora reference update has no established build or runtime regression. Installer dependency-pin compatibility remains unverified, so merge-readiness confidence is limited.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: masking GX matrix indices to six bits through the Aurora dependency update.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔇 Additional comments: 1
aurora-main-1-1: 1

1-1: Minor · Potential issue · Quick win

⚠️ Unverified finding
We couldn't verify this from the code. It is shown for review, not as a verified issue.

The new Aurora commit may change a CMake dependency pin without a corresponding update to Launcher/Prepare-Dependencies.ps1, whose pins are asserted against Aurora’s declarations.

Dependency preparation fails, preventing an installer build.

This can occur when: Preparing installer dependencies after checking out the new submodule commit, if one of its declared dependency pins differs from the script’s pin.


Review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8ac84502-62a3-4e52-a16a-f0849b0c137c
Commits

Reviewing files that changed from the base of the PR and between ae54b6e and b4d4c0e.

Files selected for processing: 1
  • aurora-main

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

@patchzyy

Copy link
Copy Markdown
Owner Author

The bump only changes lib/gx/shader.cpp and lib/gx/command_processor.cpp (457903b..4aa0141), so no CMake dependency pins move.

@patchzyy
patchzyy merged commit 3645c4a into main Oct 29, 2026
6 of 7 checks passed
@patchzyy
patchzyy deleted the bump-aurora-mtxidx branch October 29, 2026 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant