Repository navigation
deps: bump biome and turbo (patch/minor) - #1087
Merged
Merged
Conversation
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Patch/minor tooling bumps in the root
package.json, withbun.lockregenerated by bun 1.4.2:@biomejs/biome^2.4.16 → ^2.5.15turbo^2.9.17 → ^2.11.8Changes needed for Biome 2.5, each in its own commit:
style: apply Biome 2.5 formatter output: the formatter now wraps longtest.each([...])('name', fn)and similar curried calls differently. This touches 86 files and is formatter output only.test: use non-null assertions where Biome 2.5 flags unsafe optional chaining:correctness/noUnsafeOptionalChainingnow catches(a?.b as T).c. All 24 hits are in test files, and they now usea!.b, which the surrounding tests already do (for examplecommits[0]!). Behavior doesn't change: the old code would have thrown a TypeError onundefinedanyway.Left out on purpose:
lightningcss-*platform pins stay at 1.32.0.@tailwindcss/node@4.3.0depends onlightningcssat exactly1.32.0, and that is whatbun.lockresolves. Moving the optional platform pins to 1.33.0 would make them disagree with the resolvedlightningcss. They should move together with the Tailwind bump in [Deps] chore(deps): refresh MCP, rendering, framework and CSS dependencies #1037 (or after it), whenever Tailwind resolves 1.33.How to test
bun install --frozen-lockfilebun run ci: check, skills:validate, check-types, test and build should all pass.Locally,
check(same 164 warnings / 9 infos as main, 0 errors),skills:validate,check-typesandbuildpass. In this VM,bun run testhits a single ordering-dependent failure inpackages/viewer/src/components/viewer/perf-monitor.test.tsx. It reproduces on unmodifiedmaintoo and passes when the file runs alone;main's CI is green.Screenshots / screen recording
N/A — non-visual change
Checklist
bun devbun checkto verify)mainbranchNote
Low Risk
Tooling and test-only formatting/lint fixes; no production logic changes.
Reviewed by Cursor Bugbot for commit 6908fe4. Bugbot is set up for automated code reviews on this repo. Configure here.