Skip to content

eslint-config: upgrade globals to 17 - #1067

Closed
Aymericr wants to merge 1 commit into
mainfrom
cursor/deps-globals-17-6cd4
Closed

Aymericr wants to merge 1 commit into
mainfrom
cursor/deps-globals-17-6cd4

Conversation

@Aymericr

Copy link
Copy Markdown
Contributor

What does this PR do?

Upgrades globals from ^16.5.0 to ^17.13.0 in packages/eslint-config. Major upgrade, so no auto-merge.

Breaking changes (v17.0.0)

  • The audioWorklet environment is split out of browser, so browser no longer includes AudioWorklet globals.
  • Also in 17.x: browser globals are collected from both Chrome and Firefox, and new bunBuiltin, denoBuiltin, paintWorklet and sharedWorker environments are added.

Code changes: none. The configs use globals.browser and globals.serviceworker, and no linted code relies on AudioWorklet globals.

How to test

  1. bun install
  2. cd packages/ui && bun run lint. Expect it to be clean.
  3. bun run ci

Screenshots / screen recording

N/A — non-visual change

Checklist

  • I've tested this locally with bun dev
  • My code follows the existing code style (run bun check to verify)
  • I've updated relevant documentation (if applicable)
  • This PR targets the main branch

Local results: packages/ui lint is clean. bun run ci steps pass, with only the local-only test failures that main also has.

Open in Web Open in Cursor 

@Aymericr

Copy link
Copy Markdown
Contributor Author

Landed in #1071 (dc65ba0), which combined the nine major upgrades with one lockfile. Closing as superseded. #1061 stays open.

@Aymericr Aymericr closed this Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants