Repository navigation
Conversation
3 of 4 tasks
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Upgrades
eslint-plugin-react-hooksfrom ^5.2.0 to ^7.1.1 inpackages/eslint-config. Major upgrade, so no auto-merge.Breaking changes (CHANGELOG)
recommendedbecame the flat-config preset (legacy config moved torecommended-legacy). New violations:useinside try/catch, and callinguseEffectEventfunctions in arbitrary closures.recommendedandrecommended-latest, removesrecommended-latest-legacyandflat/recommended, and turns on all React Compiler rules by default inrecommended:static-components,use-memo,preserve-manual-memoization,immutability,globals,refs,set-state-in-effect,purity,set-state-in-renderand others.useEffectEventvalues as JSX props. 7.1.0 adds ESLint 10 support and stricterset-state-in-effectand ref validation.Code changes: none. The shared configs spread
pluginReactHooks.configs.recommended.rules, which still exists in 7, so the compiler rules now apply topackages/ui(and to any future consumer of@repo/eslint-config/next).How to test
bun installcd packages/ui && bun run lint. Expect it to be clean.bun run ciScreenshots / screen recording
N/A — non-visual change
Checklist
bun devbun checkto verify)mainbranchLocal results:
packages/uilint is clean.bun run cisteps pass, with only the local-only test failures thatmainalso has.