Skip to content

editor: upgrade motion to 14 - #1064

Closed
Aymericr wants to merge 1 commit into
mainfrom
cursor/deps-motion-14-6cd4
Closed

Aymericr wants to merge 1 commit into
mainfrom
cursor/deps-motion-14-6cd4

Conversation

@Aymericr

Copy link
Copy Markdown
Contributor

What does this PR do?

Upgrades motion from ^12.34.3 to ^14.2.0 in packages/editor. Major upgrade, so no auto-merge.

Breaking changes (CHANGELOG)

  • 13.0.0 removed the optional @emotion/is-prop-valid dependency. Prop filtering now has to be passed explicitly with <MotionConfig isValidProp={isPropValid}>.
  • 14.0.0 removed internal APIs that 13.5.1 had restored for framer-motion 13.0–13.4 compatibility, and pins the framer-motion, motion-dom and motion-utils dependencies.
  • Along the way (13.x): scroll/useScroll moved offset animations to the main thread, ScrollTimeline support for JS callbacks was removed, and there were AnimatePresence/layout fixes.

Code changes: none. The editor only imports public APIs from motion/react (motion, AnimatePresence, LayoutGroup, animate, useMotionValue) and never relied on @emotion/is-prop-valid.

How to test

  1. bun install && bun run ci
  2. In bun dev, check the sidebar tree expand/collapse, the action menu, the mobile panel sheet and the bottom sheet animations.

Screenshots / screen recording

Not added yet.

Checklist

  • I've tested this locally with bun dev
  • My code follows the existing code style (run bun check to verify)
  • I've updated relevant documentation (if applicable)
  • This PR targets the main branch

Local results: check, skills:validate, check-types and build pass. Tests show only the 24 local-only failures that main also has here, and none are new.

Open in Web Open in Cursor 

@Aymericr

Copy link
Copy Markdown
Contributor Author

Landed in #1071 (dc65ba0), which combined the nine major upgrades with one lockfile. Closing as superseded. #1061 stays open.

@Aymericr Aymericr closed this Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants