Repository navigation
Conversation
3 of 4 tasks
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Upgrades
motionfrom ^12.34.3 to ^14.2.0 inpackages/editor. Major upgrade, so no auto-merge.Breaking changes (CHANGELOG)
@emotion/is-prop-validdependency. Prop filtering now has to be passed explicitly with<MotionConfig isValidProp={isPropValid}>.framer-motion13.0–13.4 compatibility, and pins theframer-motion,motion-domandmotion-utilsdependencies.useScrollmoved offset animations to the main thread,ScrollTimelinesupport for JS callbacks was removed, and there wereAnimatePresence/layout fixes.Code changes: none. The editor only imports public APIs from
motion/react(motion,AnimatePresence,LayoutGroup,animate,useMotionValue) and never relied on@emotion/is-prop-valid.How to test
bun install && bun run cibun dev, check the sidebar tree expand/collapse, the action menu, the mobile panel sheet and the bottom sheet animations.Screenshots / screen recording
Not added yet.
Checklist
bun devbun checkto verify)mainbranchLocal results:
check,skills:validate,check-typesandbuildpass. Tests show only the 24 local-only failures thatmainalso has here, and none are new.