Skip to content

core, editor: upgrade nanoid to 6 - #1063

Closed
Aymericr wants to merge 3 commits into
mainfrom
cursor/deps-nanoid-6-6cd4
Closed

Aymericr wants to merge 3 commits into
mainfrom
cursor/deps-nanoid-6-6cd4

Conversation

@Aymericr

@Aymericr Aymericr commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

What does this PR do?

Upgrades nanoid from ^5.1.6 to ^6.0.2 in packages/core and packages/editor, and raises the repo's Node floor to 22 to match. Major upgrade, so no auto-merge.

Breaking changes (6.0.0 release)

  • Node.js 18 and 20 support was removed. 6.0.2 declares engines: ^22 || ^24 || >=26.
  • nanoid() and customAlphabet() are about 4× faster. The API is unchanged.

Code changes

  • None in source. Core uses customAlphabet in schema/base.ts and lib/asset-storage.ts, and its signature is unchanged.
  • Root engines.node goes from >=20.9.0 to >=22, and SETUP.md and CONTRIBUTING.md now say Node.js 22+ (approved by Aymeric). @pascal-app/cli keeps its stricter >=22.13.0. CI already runs Node 22.
  • Merged the latest main into the branch.

How to test

  1. bun install && bun run ci

Screenshots / screen recording

N/A — non-visual change

Checklist

  • I've tested this locally with bun dev
  • My code follows the existing code style (run bun check to verify)
  • I've updated relevant documentation (if applicable)
  • This PR targets the main branch

Local results: check, skills:validate, check-types and build pass. Tests show only the local-only failures that main also has here, and none are new.

Open in Web Open in Cursor 

@Aymericr

Copy link
Copy Markdown
Contributor Author

Landed in #1071 (dc65ba0), which combined the nine major upgrades with one lockfile. Closing as superseded. #1061 stays open.

@Aymericr Aymericr closed this Oct 15, 2026
@cursor
cursor Bot deleted the cursor/deps-nanoid-6-6cd4 branch October 21, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants