Allow call with null pointer for handle key and template - #367
Open
placintaalexandru wants to merge 1 commit into
Open
Allow call with null pointer for handle key and template#367placintaalexandru wants to merge 1 commit into
placintaalexandru wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some calls to Thales Luna HSMs allows the following call of
C_DeriveKey:One example is when trying to do bip32 derivation using
CKM_BIP32_CHILD_DERIVECK_BIP32_CHILD_DERIVE_PARAMS. The call works as follows:pTemplateandphKeyare null pointersCK_BIP32_CHILD_DERIVE_PARAMS.hPublicKeyandCK_BIP32_CHILD_DERIVE_PARAMS.hPrivateKeyAt the moment this is not expressable by the
cryptokicrate so I was thinking it would be nice to allow it.I tested this against a Thales Luna Network HSM
If there is interest in this, I can work on making the tests pass as well, which is trivial
Downsides
derive_key0as value so the return type should be changed as well to better reflect user's intention