Skip to content

Use line for comments helper because position is deprecated #63

Description

@dokimyj

Hi,

Octokit has a new release on Oct 2023, including 'Use line instead of position.

Not 100% sure if the replacement of position with line is the factor, but saddler-report-github gem frequently fails posting the comments on the right line of the diff since.

I evaded the posting failure by using line number instead of patched position integer.

https://github.com/packsaddle/ruby-saddler-reporter-github/blob/master/lib/saddler/reporter/github/helper.rb#L50
(I used line_no instead on local bundle and posting comment on the correct line designated has been succeeded.)

Hope this gem is still maintained, but if EOL'd already, please let me know so I can find another way to evade the failure right away...

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions