Repository navigation
Conversation
…aws-federation item **Problem** An AWS account's federated login can now refer to a federation app that is configured once and shared by several accounts, instead of holding the app details inline. The CLI reads the Okta app ID and the AWS SAML provider name only from the inline details. When the inline copy goes away, `p0 aws` role assumption with Okta SAML stops working. **Status:** Preview **Change** - When the login refers to a federation app, the CLI gets the Okta app ID from the `aws-federation` integration config and the SAML provider name from the login. - When it does not, the CLI uses the inline provider as before. - A federation app that is not an Okta app gives a clear error. - `fetchSamlAssertionForAws` takes the app ID instead of the whole login. **Type of Change** - [x] New feature **Validation** - Testing: unit tests for the federation app path, the inline path, and a non-Okta app. Not tested by hand. - Blast radius: Okta SAML role assumption for AWS only. Logins without a federation app use the same code path as before. - Risks & mitigations: role assumption with a federation app makes one more config request. **Rollout / rollback** N/A **Tracking (optional)** INT-1352 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
An AWS account's federated login can now refer to a federation app that is configured once and shared by several accounts, instead of holding the app details inline. The CLI reads the Okta app ID and the AWS SAML provider name only from the inline details. When the inline copy goes away,
p0 awsrole assumption with Okta SAML stops working.Status: Preview
Change
aws-federationintegration config and the SAML provider name from the login.fetchSamlAssertionForAwstakes the app ID instead of the whole login.Type of Change
Validation
Rollout / rollback
N/A
Tracking (optional)
INT-1352
🤖 Generated with Claude Code