Ensure boundary NTP external IPs are stored like the others - #11074
Open
bnaecker wants to merge 2 commits into
Open
Ensure boundary NTP external IPs are stored like the others#11074bnaecker wants to merge 2 commits into
bnaecker wants to merge 2 commits into
Conversation
bnaecker
commented
Aug 12, 2026
bnaecker
commented
Collaborator
- Require all service IPs of any kind to have a name and description
- Backfill boundary NTP SNAT IPs with the same naming scheme as other kinds
- Rework table constraints to allow this, and rewrite / expand tests of those constraints to be easier to modify
- Fixes NTP external IPs are stored differently from others #11020
bnaecker
force-pushed
the
ben/store-ntp-ips-the-same-way
branch
2 times, most recently
from
August 12, 2026 22:28
367ff7a to
e0f3aff
Compare
- Require all service IPs of any kind to have a name and description - Backfill boundary NTP SNAT IPs with the same naming scheme as other kinds - Rework table constraints to allow this, and rewrite / expand tests of those constraints to be easier to modify - Fixes #11020
bnaecker
force-pushed
the
ben/store-ntp-ips-the-same-way
branch
from
August 12, 2026 22:30
e0f3aff to
d50344d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.