Skip to content

chore(deploy): remove dockge handling - #104

Merged
owine merged 1 commit into
mainfrom
chore/remove-dockge
Oct 10, 2026
Merged

owine merged 1 commit into
mainfrom
chore/remove-dockge

Conversation

@owine

@owine owine commented Oct 10, 2026 •

Copy link
Copy Markdown
Owner

Dockge is retired on every host, so this removes what's left of it:

  • the has-dockge and live-dockge-path inputs
  • the HAS_DOCKGE/DOCKGE_PATH env vars and the Deploy dockge step
  • the current docs: README, CLAUDE.md and the adding-a-new-host runbook

Historical plans/specs, the migration runbook (kept verbatim on purpose) and the dockge_default rationale in ensure-shared-networks.sh are left as written.

⚠️ Merge order

A caller that passes an undefined workflow_call input fails to start. Merge these first, before Renovate bumps their compose-workflow pin past this PR:

  • owine/docker-piwine#1361
  • owine/docker-piwine-office#283

docker-zendc is archived, so it never picks up a new pin.

Verification

  • yamllint --strict is clean. actionlint reports only the known, CI-ignored job.workflow_sha items.
  • grep -i dockge across the workflows, scripts and current docs finds only historical mentions.

Summary by Sourcery

Remove obsolete Dockge handling now that Dockge is retired on every host.

Enhancements:

  • Remove the retired Dockge deployment support from the reusable workflow and update its current documentation and examples.

Documentation:

  • Update workflow documentation to reflect the removal of Dockge inputs and deployment behavior.

Chores:

  • Retain historical Dockge references where they are intentionally preserved.

Dockge is retired on every host. Drops the has-dockge and live-dockge-path
inputs, their env vars and the Deploy dockge step, plus the current docs
(README, CLAUDE.md, adding-a-new-host runbook). Historical plans/specs and the
migration runbook are left as written.

Breaking for any caller still passing either input; docker-piwine and
docker-piwine-office drop has-dockge first (docker-zendc is archived).
@sourcery-ai

sourcery-ai Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Removes the retired Dockge integration from the reusable deployment workflow, including its inputs, environment wiring, and deployment step, and synchronizes the current README and contributor documentation. Historical specifications, the migration runbook, and the shared-network rationale remain unchanged.

File-Level Changes

Change Details Files
Remove Dockge-specific workflow inputs, environment variables, and deployment logic now that Dockge is retired on every host.
  • Delete the has-dockge and live-dockge-path reusable-workflow inputs.
  • Remove HAS_DOCKGE and DOCKGE_PATH job environment variables.
  • Delete the conditional Dockge compose deployment step and update deployment-phase comments.
.github/workflows/deploy.yml
Update current documentation to describe the workflow without Dockge configuration.
  • Remove Dockge from the deployment job and input documentation.
  • Clarify that the retired Dockge inputs must not be passed by callers.
  • Remove the Dockge example input and optional-input reference.
CLAUDE.md
README.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path=".github/workflows/deploy.yml" line_range="22-26" />
<code_context>
         description: "Absolute path to the live compose tree on the runner host"
         required: true
         type: string
-      live-dockge-path:
-        description: "Absolute path to dockge's compose tree (when has-dockge=true)"
-        required: false
-        type: string
-        default: /opt/dockge
       repo-name:
         required: true
</code_context>
<issue_to_address>
**Caller deploys fail to start**

When a caller still passes either removed input when this workflow version is invoked, gitHub rejects the reusable-workflow call before any jobs run because the caller supplies an input that is no longer declared, so that repository cannot deploy.

Merge the caller updates that remove both inputs before merging this workflow change.

Also at `.github/workflows/deploy.yml:39`.
</issue_to_address>

Sourcery assessment

Approval pending. 1 finding to address first.

Blocking findings: .github/workflows/deploy.yml:26


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

Comment on lines -22 to -26
live-dockge-path:
description: "Absolute path to dockge's compose tree (when has-dockge=true)"
required: false
type: string
default: /opt/dockge

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 High · Caller deploys fail to start

When a caller still passes either removed input when this workflow version is invoked, gitHub rejects the reusable-workflow call before any jobs run because the caller supplies an input that is no longer declared, so that repository cannot deploy.

Merge the caller updates that remove both inputs before merging this workflow change.

Also at .github/workflows/deploy.yml:39.

Prompt for AI agents
In `.github/workflows/deploy.yml` at lines 22-26:

**Caller deploys fail to start**

When a caller still passes either removed input when this workflow version is invoked, gitHub rejects the reusable-workflow call before any jobs run because the caller supplies an input that is no longer declared, so that repository cannot deploy.

Merge the caller updates that remove both inputs before merging this workflow change.

Also at `.github/workflows/deploy.yml:39`.

@owine
owine merged commit 825aae0 into main Oct 10, 2026
3 checks passed
@owine
owine deleted the chore/remove-dockge branch October 10, 2026 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant