Repository navigation
chore(deploy): remove dockge handling - #104
Conversation
Dockge is retired on every host. Drops the has-dockge and live-dockge-path inputs, their env vars and the Deploy dockge step, plus the current docs (README, CLAUDE.md, adding-a-new-host runbook). Historical plans/specs and the migration runbook are left as written. Breaking for any caller still passing either input; docker-piwine and docker-piwine-office drop has-dockge first (docker-zendc is archived).
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRemoves the retired Dockge integration from the reusable deployment workflow, including its inputs, environment wiring, and deployment step, and synchronizes the current README and contributor documentation. Historical specifications, the migration runbook, and the shared-network rationale remain unchanged. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path=".github/workflows/deploy.yml" line_range="22-26" />
<code_context>
description: "Absolute path to the live compose tree on the runner host"
required: true
type: string
- live-dockge-path:
- description: "Absolute path to dockge's compose tree (when has-dockge=true)"
- required: false
- type: string
- default: /opt/dockge
repo-name:
required: true
</code_context>
<issue_to_address>
**Caller deploys fail to start**
When a caller still passes either removed input when this workflow version is invoked, gitHub rejects the reusable-workflow call before any jobs run because the caller supplies an input that is no longer declared, so that repository cannot deploy.
Merge the caller updates that remove both inputs before merging this workflow change.
Also at `.github/workflows/deploy.yml:39`.
</issue_to_address>Sourcery assessment
Approval pending. 1 finding to address first.
Blocking findings: .github/workflows/deploy.yml:26
| live-dockge-path: | ||
| description: "Absolute path to dockge's compose tree (when has-dockge=true)" | ||
| required: false | ||
| type: string | ||
| default: /opt/dockge |
There was a problem hiding this comment.
🟠 High · Caller deploys fail to start
When a caller still passes either removed input when this workflow version is invoked, gitHub rejects the reusable-workflow call before any jobs run because the caller supplies an input that is no longer declared, so that repository cannot deploy.
Merge the caller updates that remove both inputs before merging this workflow change.
Also at .github/workflows/deploy.yml:39.
Prompt for AI agents
In `.github/workflows/deploy.yml` at lines 22-26:
**Caller deploys fail to start**
When a caller still passes either removed input when this workflow version is invoked, gitHub rejects the reusable-workflow call before any jobs run because the caller supplies an input that is no longer declared, so that repository cannot deploy.
Merge the caller updates that remove both inputs before merging this workflow change.
Also at `.github/workflows/deploy.yml:39`.
Dockge is retired on every host, so this removes what's left of it:
has-dockgeandlive-dockge-pathinputsHAS_DOCKGE/DOCKGE_PATHenv vars and the Deploy dockge stepHistorical plans/specs, the migration runbook (kept verbatim on purpose) and the
dockge_defaultrationale inensure-shared-networks.share left as written.A caller that passes an undefined
workflow_callinput fails to start. Merge these first, before Renovate bumps their compose-workflow pin past this PR:docker-zendcis archived, so it never picks up a new pin.Verification
yamllint --strictis clean. actionlint reports only the known, CI-ignoredjob.workflow_shaitems.grep -i dockgeacross the workflows, scripts and current docs finds only historical mentions.Summary by Sourcery
Remove obsolete Dockge handling now that Dockge is retired on every host.
Enhancements:
Documentation:
Chores: